https://bugs.webkit.org/show_bug.cgi?id=29008#c4 WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:2084: tst_QWebFrame::arrayObjectEnumerable is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] I think tst_QWebFrame is a fine name in this test system.
Created attachment 44693 [details] Patch
style-queue ran check-webkit-style on attachment 44693 [details] without any errors.
Comment on attachment 44693 [details] Patch It wasn't initially clear to me from the ChangeLog or the change that this was related to function names. Perhaps the changelog text could be improved. You might also note that tst_ is a required name for the Qt unit testing system (I assume it's required?) because if it's optional it's not a very good name. ;)
Thanks for the patch! (In reply to comment #3) > You might also note that tst_ is a required name for the Qt unit testing system > (I assume it's required?) because if it's optional it's not a very good name. > ;) Yep, tst_ is mandatory for the files containing the test suite. The folder of a particular test can also contain utility files with classes/mockup used by the test suite.
Consider using "startswith" instead of find() == 0.
Created attachment 44702 [details] Updated with reviewer comments
(In reply to comment #5) > Consider using "startswith" instead of find() == 0. Thanks! I don't actually know python, so suggestions like this are much appreciated.
Comment on attachment 44702 [details] Updated with reviewer comments Clearing flags on attachment: 44702 Committed r52016: <http://trac.webkit.org/changeset/52016>
All reviewed patches have been landed. Closing bug.