Bug 32429 - Add capability for ChromeClient implementations to refer 'accept' attribute value of an INPUT element
Summary: Add capability for ChromeClient implementations to refer 'accept' attribute v...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kent Tamura
URL: http://www.whatwg.org/specs/web-apps/...
Keywords:
Depends on:
Blocks: HTML5Forms 32473
  Show dependency treegraph
 
Reported: 2009-12-11 06:39 PST by Kent Tamura
Modified: 2009-12-12 11:59 PST (History)
1 user (show)

See Also:


Attachments
Proposed patch (2.87 KB, patch)
2009-12-11 06:49 PST, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2009-12-11 06:39:31 PST
ChromeClient::runOpenPanel() implementation should be able to refer 'accept' attribute to support it.
Comment 1 Kent Tamura 2009-12-11 06:49:22 PST
Created attachment 44685 [details]
Proposed patch
Comment 2 WebKit Review Bot 2009-12-11 06:53:53 PST
style-queue ran check-webkit-style on attachment 44685 [details] without any errors.
Comment 3 Darin Fisher (:fishd, Google) 2009-12-11 09:25:35 PST
Comment on attachment 44685 [details]
Proposed patch

> +++ b/WebCore/rendering/RenderFileUploadControl.cpp
...
> +String RenderFileUploadControl::acceptTypes()
> +{
> +    HTMLInputElement* input = static_cast<HTMLInputElement*>(node());
> +    return input->accept();
> +}

nit: no need for the input variable, just do:

  return static_cast<HTMLInputElement*>(node())->accept();

Otherwise, R=me
Comment 4 Kent Tamura 2009-12-11 10:16:35 PST
(In reply to comment #3)

Thank you for reviewing.

> nit: no need for the input variable, just do:
> 
>   return static_cast<HTMLInputElement*>(node())->accept();
> 
> Otherwise, R=me

Fixed it, and commit manually as r52003.