Bug 32429 – Add capability for ChromeClient implementations to refer 'accept' attribute value of an INPUT element

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

ChromeClient::runOpenPanel() implementation should be able to refer 'accept' attribute to support it.

[Kent Tamura]

Created attachment 44685 [details]
Proposed patch

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 44685 [details] without any errors.

[Darin Fisher (:fishd, Google)]

Comment on attachment 44685 [details]
Proposed patch

> +++ b/WebCore/rendering/RenderFileUploadControl.cpp
...
> +String RenderFileUploadControl::acceptTypes()
> +{
> +    HTMLInputElement* input = static_cast<HTMLInputElement*>(node());
> +    return input->accept();
> +}

nit: no need for the input variable, just do:

  return static_cast<HTMLInputElement*>(node())->accept();

Otherwise, R=me

[Kent Tamura]

(In reply to comment #3)

Thank you for reviewing.

> nit: no need for the input variable, just do:
> 
>   return static_cast<HTMLInputElement*>(node())->accept();
> 
> Otherwise, R=me

Fixed it, and commit manually as r52003.