Bug 32427 - [Cairo][Qt] Alpha blending in SVG filters is wrong
Summary: [Cairo][Qt] Alpha blending in SVG filters is wrong
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 525.x (Safari 3.1)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-11 05:21 PST by Dirk Schulze
Modified: 2009-12-12 02:21 PST (History)
2 users (show)

See Also:

Attachments
correct color spacetransformation SVG Filter for Qt, Cairo (2.34 KB, patch)
2009-12-11 05:31 PST, Dirk Schulze 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2009-12-11 05:21:33 PST 
This bug is related to bug 32378 and needs the same fix for Cairo and Qt.
Comment 1 Dirk Schulze 2009-12-11 05:31:06 PST 
Created attachment 44679 [details]
correct color spacetransformation SVG Filter for Qt, Cairo

ImageBuffer::platformTransformColorSpace shouldn't transform the alpha channel on sRGB <-> linearRGB on Qt, Cairo.
Comment 2 WebKit Review Bot 2009-12-11 05:31:55 PST 
style-queue ran check-webkit-style on attachment 44679 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-12-11 15:38:13 PST 
Comment on attachment 44679 [details]
correct color spacetransformation SVG Filter for Qt, Cairo

Looks sane.  Obviously needs updates to those tests too.
Comment 4 Dirk Schulze 2009-12-12 00:45:55 PST 
(In reply to comment #3)
> (From update of attachment 44679 [details])
> Looks sane.  Obviously needs updates to those tests too.

Looks like both ports don't have pixel tests. The regression tests don't need an update.
Comment 5 WebKit Commit Bot 2009-12-12 02:21:07 PST 
Comment on attachment 44679 [details]
correct color spacetransformation SVG Filter for Qt, Cairo

Clearing flags on attachment: 44679

Committed r52049: <http://trac.webkit.org/changeset/52049>
Comment 6 WebKit Commit Bot 2009-12-12 02:21:11 PST 
All reviewed patches have been landed.  Closing bug.