RESOLVED FIXED 32411
Web Inspector: Do not use ContextMenuItem as value type in custom context menu implementation. 
https://bugs.webkit.org/show_bug.cgi?id=32411
Summary Web Inspector: Do not use ContextMenuItem as value type in custom context men...
Pavel Feldman
Reported 2009-12-11 01:57:21 PST
Rename ContextMenuSelectionHandler to ContextMenuProvider, make it responsible for populating the menu items and owning them.
Attachments
[PATCH] Proposed fix. (22.26 KB, patch)
2009-12-11 04:45 PST, Pavel Feldman 		pfeldman: commit-queue-
DetailsFormatted DiffDiff
[PATCH] Same with a style fix (22.26 KB, patch)
2009-12-11 04:48 PST, Pavel Feldman 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2009-12-11 04:45:34 PST
Created attachment 44672 [details] [PATCH] Proposed fix.
Pavel Feldman
Comment 2 2009-12-11 04:48:45 PST
Created attachment 44673 [details] [PATCH] Same with a style fix
WebKit Review Bot
Comment 3 2009-12-11 04:50:20 PST
Attachment 44673 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/page/ContextMenuProvider.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4] Skipping input 'WebCore/page/ContextMenuSelectionHandler.h': Can't open for reading Total errors found: 1
Eric Seidel (no email)
Comment 4 2009-12-28 23:37:04 PST
Ping?
Pavel Feldman
Comment 5 2009-12-29 01:27:06 PST
Landed manually long ago. Sorry for not updating the bug.
Note You need to log in before you can comment on or make changes to this bug.