Bug 32411 - Web Inspector: Do not use ContextMenuItem as value type in custom context menu implementation.
Summary: Web Inspector: Do not use ContextMenuItem as value type in custom context men...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2009-12-11 01:57 PST by Pavel Feldman
Modified: 2009-12-29 01:27 PST (History)
6 users (show)

See Also:

[PATCH] Proposed fix. (22.26 KB, patch)
2009-12-11 04:45 PST, Pavel Feldman
pfeldman: commit-queue-
Details | Formatted Diff | Diff
[PATCH] Same with a style fix (22.26 KB, patch)
2009-12-11 04:48 PST, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-12-11 01:57:21 PST
Rename ContextMenuSelectionHandler to ContextMenuProvider, make it responsible for populating the menu items and owning them.
Comment 1 Pavel Feldman 2009-12-11 04:45:34 PST
Created attachment 44672 [details]
[PATCH] Proposed fix.
Comment 2 Pavel Feldman 2009-12-11 04:48:45 PST
Created attachment 44673 [details]
[PATCH] Same with a style fix
Comment 3 WebKit Review Bot 2009-12-11 04:50:20 PST
Attachment 44673 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/page/ContextMenuProvider.h:38:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Skipping input 'WebCore/page/ContextMenuSelectionHandler.h': Can't open for reading
Total errors found: 1
Comment 4 Eric Seidel (no email) 2009-12-28 23:37:04 PST
Comment 5 Pavel Feldman 2009-12-29 01:27:06 PST
Landed manually long ago. Sorry for not updating the bug.