Bug 32396 - Move run_command onto Executive to make code which uses run_command testable
Summary: Move run_command onto Executive to make code which uses run_command testable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-10 15:18 PST by Eric Seidel (no email)
Modified: 2009-12-10 15:47 PST (History)
3 users (show)

See Also:

Attachments
Patch (7.48 KB, patch)
2009-12-10 15:20 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-12-10 15:18:05 PST 
Move run_command onto Executive to make code which uses run_command testable

I also moved the error handlers.
Comment 1 Eric Seidel (no email) 2009-12-10 15:20:41 PST 
Created attachment 44641 [details]
Patch
Comment 2 WebKit Review Bot 2009-12-10 15:24:32 PST 
style-queue ran check-webkit-style on attachment 44641 [details] without any errors.
Comment 3 Adam Barth 2009-12-10 15:26:53 PST 
Comment on attachment 44641 [details]
Patch

Ok.  Obviously we want return Executive().run_command(*args, **kwargs) to die at some point.  :)
Comment 4 Eric Seidel (no email) 2009-12-10 15:28:03 PST 
Yes, of course.  This just makes it possible for new code to "do the right thing".  I just finished breaking out the bugzilla credential logic into its own class, but needed this refactor in order to test it well.
Comment 5 WebKit Commit Bot 2009-12-10 15:47:43 PST 
Comment on attachment 44641 [details]
Patch

Clearing flags on attachment: 44641

Committed r51969: <http://trac.webkit.org/changeset/51969>
Comment 6 WebKit Commit Bot 2009-12-10 15:47:48 PST 
All reviewed patches have been landed.  Closing bug.