As spotted by Christian, there are some pieces of repeated code. Bring those refactorings plus some more cleanups.
Created attachment 44633 [details] first take
style-queue ran check-webkit-style on attachment 44633 [details] without any errors.
Comment on attachment 44633 [details] first take Wow, this looks great. I didn't consider using the visitor interface internally, but it makes for some prettier code. + virtual bool removeIfPresent + virtual void clear Do these need to be virtual? It doesn't look like they need to be overridden.
Created attachment 44681 [details] just say no to virtuals
style-queue ran check-webkit-style on attachment 44681 [details] without any errors.
(In reply to comment #3) > (From update of attachment 44633 [details]) > Wow, this looks great. I didn't consider using the visitor interface > internally, but it makes for some prettier code. > > + virtual bool removeIfPresent > + virtual void clear > > Do these need to be virtual? It doesn't look like they need to be overridden. If we're lucky, they would be overridden. But conditionals are not for SVN, removing. Thanks a lot for review.If we're lucky, they would be overridden. But conditionals are not for SVN, removing. Thanks a lot for review.
Comment on attachment 44681 [details] just say no to virtuals Clearing flags on attachment: 44681 Committed r51998: <http://trac.webkit.org/changeset/51998>
All reviewed patches have been landed. Closing bug.