Bug 32379 - Chromium: Expose devtools agent API for inspector layout tests.
Summary: Chromium: Expose devtools agent API for inspector layout tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-10 08:06 PST by Ilya Tikhonovsky
Modified: 2009-12-10 08:44 PST (History)
1 user (show)

See Also:

Attachments
[PATCH] Proposed change. (1.39 KB, patch)
2009-12-10 08:09 PST, Ilya Tikhonovsky 		pfeldman: review+
pfeldman: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2009-12-10 08:06:59 PST 
Test shell's layout tests require access to the inspector controller's methods. We expose them by means of WebDevToolsAgent interfaces as other platforms do it by means of WebInspector interfaces.
Comment 1 Ilya Tikhonovsky 2009-12-10 08:09:21 PST 
Created attachment 44616 [details]
[PATCH] Proposed change.

Note that this should be landed once implementation is committed in chromium.
Comment 2 Pavel Feldman 2009-12-10 08:12:49 PST 
Comment on attachment 44616 [details]
[PATCH] Proposed change.

I'll land it once http://codereview.chromium.org/486011 is there.
Comment 3 Pavel Feldman 2009-12-10 08:40:31 PST 
Comment on attachment 44616 [details]
[PATCH] Proposed change.

Just noticed poor naming...
Comment 4 Pavel Feldman 2009-12-10 08:44:32 PST 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/public/WebDevToolsAgent.h
Committed r51949