Bug 32352 - CommandsTest.assert_execute_outputs doesn't check stderr
Summary: CommandsTest.assert_execute_outputs doesn't check stderr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-09 16:05 PST by Eric Seidel (no email)
Modified: 2009-12-11 14:39 PST (History)
3 users (show)

See Also:

Attachments
Patch (5.53 KB, patch)
2009-12-11 14:27 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-12-09 16:05:24 PST 
CommandsTest.assert_execute_outputs doesn't check stderr

It tries to, but fails:

        self.assertEqual(expected_stderr, expected_stderr)

Fixing this will undoubtably reveal a bunch of failures.
Comment 1 Eric Seidel (no email) 2009-12-11 14:27:35 PST 
Created attachment 44708 [details]
Patch
Comment 2 WebKit Review Bot 2009-12-11 14:29:02 PST 
style-queue ran check-webkit-style on attachment 44708 [details] without any errors.
Comment 3 Adam Barth 2009-12-11 14:29:30 PST 
Comment on attachment 44708 [details]
Patch

Fantabulous!
Comment 4 WebKit Commit Bot 2009-12-11 14:39:36 PST 
Comment on attachment 44708 [details]
Patch

Clearing flags on attachment: 44708

Committed r52025: <http://trac.webkit.org/changeset/52025>
Comment 5 WebKit Commit Bot 2009-12-11 14:39:41 PST 
All reviewed patches have been landed.  Closing bug.