Bug 32348 - Web Inspector: Add context menu actions for DOM tree.
Summary: Web Inspector: Add context menu actions for DOM tree.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-09 14:38 PST by Pavel Feldman
Modified: 2009-12-10 04:54 PST (History)
4 users (show)

See Also:


Attachments
[IMAGE] Context menu 1 (135.59 KB, image/png)
2009-12-09 14:38 PST, Pavel Feldman
no flags Details
[IMAGE] Context menu 2 (128.39 KB, image/png)
2009-12-09 14:39 PST, Pavel Feldman
no flags Details
[IMAGE] Context menu 3 (130.82 KB, image/png)
2009-12-09 14:40 PST, Pavel Feldman
no flags Details
[PATCH] Proposed change (14.60 KB, patch)
2009-12-09 14:44 PST, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff
[PATCH] Patch with local listener and comment addressed. (12.99 KB, patch)
2009-12-09 15:03 PST, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-12-09 14:38:07 PST
Drive-by tiny refactoring of context menu and tree outline cleanup.

Items available on tag:
 Add Attribute
-----------
 Delete Node

Items available on attribute:
 Add Attribute
 Edit Attribute
-----------
 Delete Node

Items available on text:
 Edit Text
Comment 1 Pavel Feldman 2009-12-09 14:38:53 PST
Created attachment 44566 [details]
[IMAGE] Context menu 1
Comment 2 Pavel Feldman 2009-12-09 14:39:18 PST
Created attachment 44567 [details]
[IMAGE] Context menu 2
Comment 3 Pavel Feldman 2009-12-09 14:40:11 PST
Created attachment 44568 [details]
[IMAGE] Context menu 3
Comment 4 Pavel Feldman 2009-12-09 14:44:22 PST
Created attachment 44569 [details]
[PATCH] Proposed change
Comment 5 Timothy Hatcher 2009-12-09 14:56:37 PST
Comment on attachment 44569 [details]
[PATCH] Proposed change

> +    this.element.addEventListener("contextmenu", this._contextMenuEventFired.bind(this), true);
> +
>  }

Extra line.
Comment 6 Pavel Feldman 2009-12-09 15:03:00 PST
Created attachment 44573 [details]
[PATCH] Patch with local listener and comment addressed.
Comment 7 Pavel Feldman 2009-12-10 04:54:13 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/English.lproj/localizedStrings.js
	M	WebCore/inspector/front-end/ContextMenu.js
	M	WebCore/inspector/front-end/ElementsTreeOutline.js
	M	WebCore/inspector/front-end/ObjectPropertiesSection.js
	M	WebCore/inspector/front-end/ResourceView.js
	M	WebCore/inspector/front-end/ResourcesPanel.js
	M	WebCore/inspector/front-end/StylesSidebarPane.js
	M	WebCore/inspector/front-end/inspector.js
	M	WebCore/inspector/front-end/treeoutline.js
Committed r51946