Bug 32344 - exception thrown when running apply-patches
Summary: exception thrown when running apply-patches
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-12-09 13:21 PST by Eric Seidel (no email)
Modified: 2009-12-09 22:05 PST (History)
2 users (show)

See Also:

Patch (1.97 KB, patch)
2009-12-09 13:29 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-12-09 13:21:56 PST
> bugzilla-tool apply-patches 32313
Cleaning working directory
Updating working directory
Traceback (most recent call last):
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 104, in <module>
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/multicommandtool.py", line 253, in main
    return command.check_arguments_and_execute(args_after_command_name, self)
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/multicommandtool.py", line 99, in check_arguments_and_execute
    return self.execute(command_options, command_args, tool) or 0
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/commands/download.py", line 86, in execute
    WebKitApplyingScripts.setup_for_patch_apply(tool, options)
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/commands/download.py", line 105, in setup_for_patch_apply
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/buildsteps.py", line 115, in run
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/buildsteps.py", line 67, in port
    self._port = WebKitPort.port(self._options.port)
AttributeError: Values instance has no attribute 'port'

This is fallout from Adam's recent restructuring.
Comment 1 Adam Barth 2009-12-09 13:23:46 PST
Hum...  There may be more examples of this.  Patch forthcoming.
Comment 2 Adam Barth 2009-12-09 13:29:10 PST
Created attachment 44558 [details]
Comment 3 Eric Seidel (no email) 2009-12-09 13:33:04 PST
Comment on attachment 44558 [details]

OK.  Seems port shoudl just be a global option, no?
Comment 4 WebKit Commit Bot 2009-12-09 14:25:43 PST
Comment on attachment 44558 [details]

Clearing flags on attachment: 44558

Committed r51923: <http://trac.webkit.org/changeset/51923>
Comment 5 WebKit Commit Bot 2009-12-09 14:25:48 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Adam Barth 2009-12-09 22:05:20 PST
> OK.  Seems port shoudl just be a global option, no?

Yes.  We need global options to not suck though.  :)