Bug 32341 - layout tests timeout when run under valgrind
Summary: layout tests timeout when run under valgrind
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-09 12:48 PST by Doug Muir
Modified: 2010-01-19 14:12 PST (History)
4 users (show)

See Also:


Attachments
patch that corrects tests that timeout under valgrind (2.96 KB, patch)
2009-12-09 12:48 PST, Doug Muir
ggaren: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
revised patch sans tabs (2.95 KB, patch)
2010-01-15 20:46 PST, Geoffrey Garen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Doug Muir 2009-12-09 12:48:36 PST
Created attachment 44557 [details]
patch that corrects tests that timeout under valgrind

A few of the layout tests are timing out when run under valgrind due to timeout callbacks being invoked before specific DOM elements have been parsed/created.
Comment 1 Geoffrey Garen 2010-01-15 16:23:08 PST
Comment on attachment 44557 [details]
patch that corrects tests that timeout under valgrind

r=me
Comment 2 WebKit Commit Bot 2010-01-15 16:57:26 PST
Comment on attachment 44557 [details]
patch that corrects tests that timeout under valgrind

Rejecting patch 44557 from commit-queue.

Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Last 500 characters of output:
Tests/http/tests/misc/timer-vs-loading.html
A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can't write to stream: Broken pipe

    The following files contain tab characters:

        trunk/LayoutTests/ChangeLog

    Please use spaces instead to indent.
    If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.
 at /usr/local/git/libexec/git-core/git-svn line 558


Full output: http://webkit-commit-queue.appspot.com/results/190616
Comment 3 Geoffrey Garen 2010-01-15 20:46:53 PST
Created attachment 46731 [details]
revised patch sans tabs
Comment 4 WebKit Commit Bot 2010-01-15 21:05:56 PST
Comment on attachment 46731 [details]
revised patch sans tabs

Clearing flags on attachment: 46731

Committed r53356: <http://trac.webkit.org/changeset/53356>
Comment 5 WebKit Commit Bot 2010-01-15 21:06:03 PST
All reviewed patches have been landed.  Closing bug.