RESOLVED FIXED32337
Chrome build bustage needs fixing 
https://bugs.webkit.org/show_bug.cgi?id=32337
Summary Chrome build bustage needs fixing
Michael Nordman
Reported 2009-12-09 12:03:31 PST
r51884 broke things
Attachments
fix compile errors (7.41 KB, patch)
2009-12-09 12:04 PST, Michael Nordman 		michaeln: review-
DetailsFormatted DiffDiff
Fix compile errors (8.25 KB, patch)
2009-12-09 12:19 PST, Michael Nordman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Nordman
Comment 1 2009-12-09 12:04:51 PST
Created attachment 44552 [details] fix compile errors
WebKit Review Bot
Comment 2 2009-12-09 12:08:39 PST
Attachment 44552 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:643: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:673: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:721: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:747: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:841: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:866: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 6
Michael Nordman
Comment 3 2009-12-09 12:11:14 PST
bah... i misssed another compile error... new patch coming soon
Michael Nordman
Comment 4 2009-12-09 12:19:53 PST
Created attachment 44555 [details] Fix compile errors
WebKit Review Bot
Comment 5 2009-12-09 12:24:47 PST
Attachment 44555 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:643: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:673: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:721: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:747: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:841: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:866: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 6
Dimitri Glazkov (Google)
Comment 6 2009-12-09 12:27:11 PST
Ok, this is not cool. Peterson, please compile your patches before landing.
Dimitri Glazkov (Google)
Comment 7 2009-12-09 12:29:06 PST
Comment on attachment 44555 [details] Fix compile errors ok.
WebKit Commit Bot
Comment 8 2009-12-09 12:36:46 PST
Comment on attachment 44555 [details] Fix compile errors Clearing flags on attachment: 44555 Committed r51915: <http://trac.webkit.org/changeset/51915>
WebKit Commit Bot
Comment 9 2009-12-09 12:36:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.