Bug 32337 - Chrome build bustage needs fixing
Summary: Chrome build bustage needs fixing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Blocker
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-09 12:03 PST by Michael Nordman
Modified: 2009-12-09 12:36 PST (History)
4 users (show)

See Also:


Attachments
fix compile errors (7.41 KB, patch)
2009-12-09 12:04 PST, Michael Nordman
michaeln: review-
Details | Formatted Diff | Diff
Fix compile errors (8.25 KB, patch)
2009-12-09 12:19 PST, Michael Nordman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Nordman 2009-12-09 12:03:31 PST
r51884 broke things
Comment 1 Michael Nordman 2009-12-09 12:04:51 PST
Created attachment 44552 [details]
fix compile errors
Comment 2 WebKit Review Bot 2009-12-09 12:08:39 PST
Attachment 44552 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:643:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:673:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:721:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:747:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:841:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:866:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 6
Comment 3 Michael Nordman 2009-12-09 12:11:14 PST
bah... i misssed another compile error... new patch coming soon
Comment 4 Michael Nordman 2009-12-09 12:19:53 PST
Created attachment 44555 [details]
Fix compile errors
Comment 5 WebKit Review Bot 2009-12-09 12:24:47 PST
Attachment 44555 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:643:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:673:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:721:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:747:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:841:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:866:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 6
Comment 6 Dimitri Glazkov (Google) 2009-12-09 12:27:11 PST
Ok, this is not cool. Peterson, please compile your patches before landing.
Comment 7 Dimitri Glazkov (Google) 2009-12-09 12:29:06 PST
Comment on attachment 44555 [details]
Fix compile errors

ok.
Comment 8 WebKit Commit Bot 2009-12-09 12:36:46 PST
Comment on attachment 44555 [details]
Fix compile errors

Clearing flags on attachment: 44555

Committed r51915: <http://trac.webkit.org/changeset/51915>
Comment 9 WebKit Commit Bot 2009-12-09 12:36:51 PST
All reviewed patches have been landed.  Closing bug.