Bug 32333 - Layout test for video element on HTTP
Summary: Layout test for video element on HTTP
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Hin-Chung Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-09 11:29 PST by Hin-Chung Lam
Modified: 2010-01-04 13:20 PST (History)
2 users (show)

See Also:


Attachments
new test + expectation (3.07 KB, patch)
2009-12-09 14:38 PST, Hin-Chung Lam
eric.carlson: review+
eric.carlson: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hin-Chung Lam 2009-12-09 11:29:59 PST
Add a new layout test that can test the user agent's ability to handle caching of video resources.

To start with a simple case, this test will do the following:

1. Load the resource, until we receive canplaythrough event
2. Remove the element
3. Load the resource the second time, until we receive canplaythrough event

If the user agent performs caching of video resource, the first load will have the resource goes into cache and the second load will work fine too.

If the user agent doesn't do any caching, both load will always work fine.
Comment 1 Hin-Chung Lam 2009-12-09 14:38:12 PST
Created attachment 44564 [details]
new test + expectation
Comment 2 Eric Carlson 2009-12-09 17:49:46 PST
Comment on attachment 44564 [details]
new test + expectation

As we discussed in irc, the patch looks good but it would be helpful to have more information in the ChangeLog about why it is necessary to copy the test movies instead of using the originals like the other http media tests do.

r=me with some extra comments
Comment 3 Hin-Chung Lam 2009-12-09 17:58:11 PST
Thanks for the review, will fix the change log before I commit.
Comment 4 Eric Seidel (no email) 2009-12-28 22:40:44 PST
Attachment 44564 [details] was posted by a committer and has review+, assigning to Hin-Chung Lam for commit.
Comment 5 Eric Seidel (no email) 2009-12-28 23:27:57 PST
Looks like this has been r+'d for a little over two weeks.  I assume things are just a bit slow due to the holiday season.  Or maybe this was already landed?
Comment 6 Hin-Chung Lam 2010-01-04 13:20:38 PST
(In reply to comment #5)
> Looks like this has been r+'d for a little over two weeks.  I assume things are
> just a bit slow due to the holiday season.  Or maybe this was already landed?

Sorry for late response. This has been submitted as http://trac.webkit.org/changeset/51966.

I'm closing it, thanks for reminding me.