Bug 32328 - Some script binding methods lack INSPECTOR guards
Summary: Some script binding methods lack INSPECTOR guards
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-09 10:38 PST by Steve Block
Modified: 2009-12-09 14:54 PST (History)
2 users (show)

See Also:

Attachments
Patch 1 for Bug 32328 (2.22 KB, patch)
2009-12-09 10:48 PST, Steve Block 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2009-12-09 10:38:56 PST 
ScriptValue::quarantineValue and some overloads of ScriptGlobalObject::set use types which are only defined when INSPECTOR is enabled. These methods should be guarded with ENABLE(INSPECTOR).
Comment 1 Steve Block 2009-12-09 10:48:21 PST 
Created attachment 44545 [details]
Patch 1 for Bug 32328
Comment 2 WebKit Review Bot 2009-12-09 10:50:50 PST 
style-queue ran check-webkit-style on attachment 44545 [details] without any errors.
Comment 3 WebKit Commit Bot 2009-12-09 14:54:24 PST 
Comment on attachment 44545 [details]
Patch 1 for Bug 32328

Clearing flags on attachment: 44545

Committed r51927: <http://trac.webkit.org/changeset/51927>
Comment 4 WebKit Commit Bot 2009-12-09 14:54:29 PST 
All reviewed patches have been landed.  Closing bug.