Bug 32324 - [Chromium] Incorrectly sends WebFrameClient notifications for a detached frame
Summary: [Chromium] Incorrectly sends WebFrameClient notifications for a detached frame
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
Depends on:
Reported: 2009-12-09 08:52 PST by Darin Fisher (:fishd, Google)
Modified: 2009-12-09 13:37 PST (History)
3 users (show)

See Also:

v1 patch (4.72 KB, patch)
2009-12-09 08:58 PST, Darin Fisher (:fishd, Google)
eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff
v2 patch (5.94 KB, patch)
2009-12-09 13:33 PST, Darin Fisher (:fishd, Google)
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2009-12-09 08:52:17 PST
[Chromium] Incorrectly sends WebFrameClient notifications for a detached frame

This bug manifests itself as a failure to pass http/tests/loading/gmail-assert-on-load.html

The fix is to suppress WebFrameClient callbacks when FrameLoaderClient::detachedFromParent3 is called.
Comment 1 Darin Fisher (:fishd, Google) 2009-12-09 08:58:33 PST
Created attachment 44541 [details]
v1 patch
Comment 2 WebKit Review Bot 2009-12-09 10:13:48 PST
style-queue ran check-webkit-style on attachment 44541 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-12-09 13:26:44 PST
Looks sane to me.
Comment 4 Eric Seidel (no email) 2009-12-09 13:27:35 PST
Comment on attachment 44541 [details]
v1 patch

This is missing a ChangeLog describing what tests this fixes.  Otherwise it looks fine though (assuming this is covered by a test).  If it's not changing a test, then that's bad, and I would r- this.
Comment 5 Darin Fisher (:fishd, Google) 2009-12-09 13:30:55 PST
oops, not sure why my changelog entry didn't make it into the patch.  let me upload again.
Comment 6 Darin Fisher (:fishd, Google) 2009-12-09 13:33:04 PST
Created attachment 44559 [details]
v2 patch

With ChangeLog entry this time.
Comment 7 Eric Seidel (no email) 2009-12-09 13:34:28 PST
Comment on attachment 44559 [details]
v2 patch

Comment 8 Darin Fisher (:fishd, Google) 2009-12-09 13:37:19 PST
Landed as http://trac.webkit.org/changeset/51917