WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
323232
Fix testLibJSCTools's CorpseSnapshotTest and CorpseSymbolTest to run better for ASAN builds.
https://bugs.webkit.org/show_bug.cgi?id=323232
Summary
Fix testLibJSCTools's CorpseSnapshotTest and CorpseSymbolTest to run better f...
Mark Lam
Reported
2026-09-02 11:59:23 PDT
CorpseSymbolTest was previously looking up the symbol for `malloc`. ASAN builds overrides `malloc` with its own implementation, which causes the test to fail. We now change CorpseSymbolTest to look up `tolower` from the standard C library instead. A test in CorpseSnapshotTest was doing 100 interactions of creating Snapshots and requesting their threads list. This was done to see if the operations leaked any mach ports. As a result, this test was taking on the order of 1.1 seconds to run for a Release / Debug build, and ~9 seconds for an ASAN build. CorpseSnapshotTest is now fixed to run that test exactly once and confirm that there's no increase in mach ports allocated. CorpseSnapshotTest now takes 60-90 ms to run.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2026-09-02 11:59:55 PDT
<
rdar://problem/186484113
>
Mark Lam
Comment 2
2026-09-02 12:12:09 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/73072
EWS
Comment 3
2026-09-02 14:54:44 PDT
Committed
320353@main
(951d88a0fe8b): <
https://commits.webkit.org/320353@main
> Reviewed commits have been landed. Closing PR #73072 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug