Bug 32321 – ENABLE_ORIENTATION_EVENTS does not compile

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Patrick]

Created attachment 44535 [details]
Patch to fix build.

Frame.cpp does not compile due to a change in dispatchWindowEvent. Attached is a patch to fix the build.

[Darin Fisher (:fishd, Google)]

Comment on attachment 44535 [details]
Patch to fix build.

> Index: WebCore/ChangeLog
...
> +        Fix the build with ENABLE_ORIENTATION_EVENTS
> +
> +        * page/Frame.cpp:
> +        (WebCore::Frame::sendOrientationChangeEvent):

the change is good, but please revise the patch to include a bug link in the ChangeLog.

[Patrick]

Created attachment 44537 [details]
Update changelog with bug url.

[WebKit Commit Bot]

Comment on attachment 44537 [details]
Update changelog with bug url.

Rejecting patch 44537 from commit-queue.

Unexpected failure when landing patch!  Please file a bug against bugzilla-tool.
Failed to run "['WebKitTools/Scripts/bugzilla-tool', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '44537']" exit_code: 1
Last 500 characters of output:
nd_handle_errors
    self.run()
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 54, in run
    self.clean()
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 81, in clean
    step.run()
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/buildsteps.py", line 101, in run
    os.chdir(self._tool._scm.checkout_root)
AttributeError: 'NoneType' object has no attribute 'checkout_root'

[Patrick]

Oops, cq failed. Can someone landed this patch manually?

[Eric Seidel (no email)]

Comment on attachment 44537 [details]
Update changelog with bug url.

Sorry for the noise.  Adam believes to have fixed the issue.  I've restarted the commit bot.

[WebKit Commit Bot]

Comment on attachment 44537 [details]
Update changelog with bug url.

Clearing flags on attachment: 44537

Committed r51910: <http://trac.webkit.org/changeset/51910>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

Please be sure to leave the "Reviewed by NOBODY (OOPS!)." line in your ChangeLogs so that the scripts can correctly mark a reviewer when landing.