Bug 32313 – queue sub-commands need --status-host so they can report status

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Eric Seidel (no email)]

queue sub-commands need --status-host so they can report status

We should really pass all of the global arguments down to the sub-commands.  Not sure exactly how we'll do that yet.  Global argument parsing is not well abstracted between MultiCommandTool and BugzillaTool.

Once we do this, then sub-commands will have a StatusBot.  Once that's the case, then it's a one-line patch to dump build output into the status server.

[Eric Seidel (no email)]

Created attachment 44523 [details]
WIP patch

[Eric Seidel (no email)]

Created attachment 44850 [details]
Patch

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 44850 [details] without any errors.

[Eric Seidel (no email)]

Comment on attachment 44850 [details]
Patch

Going to land this one by hand.

[Eric Seidel (no email)]

Comment on attachment 44850 [details]
Patch

Adding back to the CQ for testing.

[Eric Seidel (no email)]

Comment on attachment 44850 [details]
Patch

Rejecting patch 44850 from commit-queue.

Unexpected failure when landing patch!  Please file a bug against bugzilla-tool.
Failed to run "['/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool', '--status-host', 'localhost:8080', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '44850']" exit_code: 1
Usage: bugzilla-tool [options] COMMAND [ARGS]

bugzilla-tool: error: --status-host option requires an argument

Type "bugzilla-tool --help" to see usage.

[Eric Seidel (no email)]

Comment on attachment 44850 [details]
Patch

Adding back to the CQ for testing.

[Eric Seidel (no email)]

Comment on attachment 44850 [details]
Patch

Rejecting patch 44850 from commit-queue.

Unexpected failure when landing patch!  Please file a bug against bugzilla-tool.
Failed to run "['/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool', '--status-host=localhost:8080', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '44850']" exit_code: 1
ERROR: Builders ["Leopard Intel Release (Tests)", "Leopard Intel Debug (Tests)"] are red, please do not commit.
See http://build.webkit.org.
Pass --ignore-builders to bypass this check.

[Eric Seidel (no email)]

Comment on attachment 44850 [details]
Patch

Adding back to the CQ for testing.

[Eric Seidel (no email)]

Comment on attachment 44850 [details]
Patch

Rejecting patch 44850 from commit-queue.

Unexpected failure when landing patch!  Please file a bug against bugzilla-tool.
Failed to run "['/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool', '--status-host=localhost:8080', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '44850']" exit_code: 1
Last 500 characters of output:
nce.run_and_handle_errors(tool, options, state)
  File "/Projects/WebKit/WebKitTools/Scripts/modules/stepsequence.py", line 75, in run_and_handle_errors
    command.handle_script_error(tool, state, e)
  File "/Projects/WebKit/WebKitTools/Scripts/modules/commands/queues.py", line 150, in handle_script_error
    tool.status_bot.update_status(cls.name, "Patch %s failed: %s" % (patch['id'], script_error.message), patch, StringIO(script_error.output))
NameError: global name 'StringIO' is not defined

[Eric Seidel (no email)]

Comment on attachment 44850 [details]
Patch

Adding back to the CQ for testing.

[Eric Seidel (no email)]

Comment on attachment 44850 [details]
Patch

Rejecting patch 44850 from commit-queue.

Failed to run "['WebKitTools/Scripts/build-webkit']" exit_code: 1
Last 500 characters of output:
ild/JavaScriptCore.build/Debug/JavaScriptCore.build/DerivedSources/i386 -I/build/JavaScriptCore.build/Debug/JavaScriptCore.build/DerivedSources -include /var/folders/zz/zzzivhrRnAmviuee++2Pvk+-4yw/-Caches-/com.apple.Xcode.72687/SharedPrecompiledHeaders/JavaScriptCorePrefix-bqeihplanvwsgbdubtwylvhovamq/JavaScriptCorePrefix.h -c /Projects/WebKitSVN/JavaScriptCore/runtime/Collector.cpp -o /build/JavaScriptCore.build/Debug/JavaScriptCore.build/Objects-normal/i386/Collector.o
** BUILD INTERRUPTED **

[Eric Seidel (no email)]

Committed r52145: <http://trac.webkit.org/changeset/52145>