Bug 32310 - [bzt] Convert Build to use Sequence
Summary: [bzt] Convert Build to use Sequence
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-09 01:00 PST by Adam Barth
Modified: 2009-12-09 01:24 PST (History)
1 user (show)

See Also:

Attachments
Patch (5.68 KB, patch)
2009-12-09 01:01 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (9.00 KB, patch)
2009-12-09 01:06 PST, Adam Barth 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-12-09 01:00:00 PST 
LandingSequence is on the way out!
Comment 1 Adam Barth 2009-12-09 01:01:05 PST 
Created attachment 44518 [details]
Patch
Comment 2 Eric Seidel (no email) 2009-12-09 01:04:53 PST 
Comment on attachment 44518 [details]
Patch

Should be StepSequence
Comment 3 Adam Barth 2009-12-09 01:06:45 PST 
Created attachment 44520 [details]
Patch
Comment 4 Eric Seidel (no email) 2009-12-09 01:22:42 PST 
Comment on attachment 44520 [details]
Patch

 45 # FIXME: This class is slowing being killed and replaced with Sequencer.

StepSequence

The trailing none is unclear:
 59         self._sequence.run_and_handle_errors(tool, options, None)

 45         collected_options = [option for option in set(collected_options)]

call sorted()

CheckoutNeedsUpdate does not belong in this thing. :(

Needs the above tweaks before landing.
Comment 5 Adam Barth 2009-12-09 01:24:52 PST 
Committed r51893: <http://trac.webkit.org/changeset/51893>