Bug 32305 - run_command and ScriptError should move into processutils.py
Summary: run_command and ScriptError should move into processutils.py
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-08 23:38 PST by Eric Seidel (no email)
Modified: 2009-12-08 23:51 PST (History)
2 users (show)

See Also:

Attachments
Patch (34.59 KB, patch)
2009-12-08 23:42 PST, Eric Seidel (no email) 		abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-12-08 23:38:34 PST 
run_command and ScriptError should move into processutils.py

We need to unify run_command and the other run_ methods.  This is a pre-cursor to that unification.
Comment 1 Eric Seidel (no email) 2009-12-08 23:42:05 PST 
Created attachment 44513 [details]
Patch
Comment 2 WebKit Review Bot 2009-12-08 23:43:19 PST 
style-queue ran check-webkit-style on attachment 44513 [details] without any errors.
Comment 3 Adam Barth 2009-12-08 23:46:36 PST 
Comment on attachment 44513 [details]
Patch

Ok.  This is good, but only the first step.  We need an executive class, but we'll get to that.  Also, there's the indent issue I mentioned.
Comment 4 Eric Seidel (no email) 2009-12-08 23:51:58 PST 
Committed r51888: <http://trac.webkit.org/changeset/51888>