This is a bug report to make the following changes and clarifications to the coding style guidelines: (1) Add this to the guidelines: Do not use statements of the form "using std:foo" in implementation files. Use "using namespace std" instead. (The script currently enforces this rule, but for header files and not just implementation files.) (2) Clarify that the rule to put "using namespace" statements near the beginning of a file applies only to implementation files. (It currently applies also to header files.) Also, strengthen the rule so it applies to all "using" statements in implementation files and not just "using namespace" statements. (The above is excerpted from an e-mail to the webkit-dev list -- linked to by the URL for this report.)
Created attachment 44509 [details] Proposed patch Changes made as reported. Also, all the "using" statement style guidelines now lead with "In header files" or "In implementation files," etc. so it is immediately obvious what types of files each rule applies to.
style-queue ran check-webkit-style on attachment 44509 [details] without any errors.
Comment on attachment 44509 [details] Proposed patch > +<li>In header files in the WTF sub-library, however, it is acceptable > +to use "using" declarations at the end of the file to include one > +or more names in the WTF namespace into the global scope. I think the use of the verb "include" here is strange. I think it should be "add" or "import" instead.
Created attachment 44543 [details] Revised patch Changed the two uses of "include" to "import" -- as suggested.
style-queue ran check-webkit-style on attachment 44543 [details] without any errors.
Comment on attachment 44543 [details] Revised patch Clearing flags on attachment: 44543 Committed r51929: <http://trac.webkit.org/changeset/51929>
All reviewed patches have been landed. Closing bug.