Bug 32296 - Implement 'select all' for WebKit/win/WebFrame
Summary: Implement 'select all' for WebKit/win/WebFrame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-08 16:23 PST by Brent Fulgham
Modified: 2009-12-09 12:07 PST (History)
2 users (show)

See Also:


Attachments
Provide simple selectAll implementation. (1.09 KB, patch)
2009-12-08 16:26 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff
Provide simple selectAll implementation. (1.10 KB, patch)
2009-12-08 16:28 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2009-12-08 16:23:47 PST
The CG Windows port of WebKit has not needed support for a "selectAll" operation on the WebFrame.  Most other browsers on the Windows platform (e.g., Firefox, IE) do provide a right-click contextual "Select All" menu.

This patch provides a selectAll implementation that can be used to drive a platform-specific "Select All" feature.
Comment 1 Brent Fulgham 2009-12-08 16:26:26 PST
Created attachment 44496 [details]
Provide simple selectAll implementation.
Comment 2 Brent Fulgham 2009-12-08 16:28:30 PST
Created attachment 44497 [details]
Provide simple selectAll implementation.
Comment 3 Brent Fulgham 2009-12-08 16:29:02 PST
Comment on attachment 44497 [details]
Provide simple selectAll implementation.

Whitespace (tabs) corrected.
Comment 4 WebKit Review Bot 2009-12-08 16:29:56 PST
style-queue ran check-webkit-style on attachment 44497 [details] without any errors.
Comment 5 Darin Adler 2009-12-09 09:35:58 PST
Comment on attachment 44497 [details]
Provide simple selectAll implementation.

> +    if (!coreFrame->editor()->command("SelectAll").execute())
> +        return E_FAIL;

I think coreFrame->selection()->selectAll() would be better here. But this seems OK.
Comment 6 WebKit Commit Bot 2009-12-09 10:27:30 PST
Comment on attachment 44497 [details]
Provide simple selectAll implementation.

Rejecting patch 44497 from commit-queue.

Unexpected failure when landing patch!  Please file a bug against bugzilla-tool.
Failed to run "['WebKitTools/Scripts/bugzilla-tool', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '44497']" exit_code: 1
Last 500 characters of output:
nd_handle_errors
    self.run()
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 54, in run
    self.clean()
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 81, in clean
    step.run()
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/buildsteps.py", line 101, in run
    os.chdir(self._tool._scm.checkout_root)
AttributeError: 'NoneType' object has no attribute 'checkout_root'
Comment 7 Eric Seidel (no email) 2009-12-09 11:37:36 PST
Comment on attachment 44497 [details]
Provide simple selectAll implementation.

Sorry for the noise.  Adam believes to have fixed the issue.  I've restarted the commit bot.
Comment 8 WebKit Commit Bot 2009-12-09 12:07:07 PST
Comment on attachment 44497 [details]
Provide simple selectAll implementation.

Clearing flags on attachment: 44497

Committed r51911: <http://trac.webkit.org/changeset/51911>
Comment 9 WebKit Commit Bot 2009-12-09 12:07:12 PST
All reviewed patches have been landed.  Closing bug.