Bug 32296 – Implement 'select all' for WebKit/win/WebFrame

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brent Fulgham]

The CG Windows port of WebKit has not needed support for a "selectAll" operation on the WebFrame.  Most other browsers on the Windows platform (e.g., Firefox, IE) do provide a right-click contextual "Select All" menu.

This patch provides a selectAll implementation that can be used to drive a platform-specific "Select All" feature.

[Brent Fulgham]

Created attachment 44496 [details]
Provide simple selectAll implementation.

[Brent Fulgham]

Created attachment 44497 [details]
Provide simple selectAll implementation.

[Brent Fulgham]

Comment on attachment 44497 [details]
Provide simple selectAll implementation.

Whitespace (tabs) corrected.

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 44497 [details] without any errors.

[Darin Adler]

Comment on attachment 44497 [details]
Provide simple selectAll implementation.

> +    if (!coreFrame->editor()->command("SelectAll").execute())
> +        return E_FAIL;

I think coreFrame->selection()->selectAll() would be better here. But this seems OK.

[WebKit Commit Bot]

Comment on attachment 44497 [details]
Provide simple selectAll implementation.

Rejecting patch 44497 from commit-queue.

Unexpected failure when landing patch!  Please file a bug against bugzilla-tool.
Failed to run "['WebKitTools/Scripts/bugzilla-tool', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '44497']" exit_code: 1
Last 500 characters of output:
nd_handle_errors
    self.run()
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 54, in run
    self.clean()
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 81, in clean
    step.run()
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/buildsteps.py", line 101, in run
    os.chdir(self._tool._scm.checkout_root)
AttributeError: 'NoneType' object has no attribute 'checkout_root'

[Eric Seidel (no email)]

Comment on attachment 44497 [details]
Provide simple selectAll implementation.

Sorry for the noise.  Adam believes to have fixed the issue.  I've restarted the commit bot.

[WebKit Commit Bot]

Comment on attachment 44497 [details]
Provide simple selectAll implementation.

Clearing flags on attachment: 44497

Committed r51911: <http://trac.webkit.org/changeset/51911>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.