Bug 32289 - Mouse click count lost in WebMouseEventBuilder conversion
Summary: Mouse click count lost in WebMouseEventBuilder conversion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Stuart Morgan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-08 14:42 PST by Stuart Morgan
Modified: 2009-12-09 11:36 PST (History)
4 users (show)

See Also:

Attachments
Add clickCount to conversion (1.15 KB, patch)
2009-12-08 15:06 PST, Stuart Morgan 		fishd: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stuart Morgan 2009-12-08 14:42:09 PST 
WebMouseEventBuilder::WebMouseEventBuilder in WebInputEventConversion.cpp fails to pull the source event's "detail" field, which is where the click count is stored in MouseEvent, so all mouse events going through it end up with a clickCount of 0.
Comment 1 Stuart Morgan 2009-12-08 15:06:26 PST 
Created attachment 44490 [details]
Add clickCount to conversion
Comment 2 WebKit Review Bot 2009-12-08 15:08:15 PST 
style-queue ran check-webkit-style on attachment 44490 [details] without any errors.
Comment 3 WebKit Commit Bot 2009-12-09 08:41:06 PST 
Comment on attachment 44490 [details]
Add clickCount to conversion

Rejecting patch 44490 from commit-queue.

Unexpected failure when landing patch!  Please file a bug against bugzilla-tool.
Failed to run "['WebKitTools/Scripts/bugzilla-tool', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '44490']" exit_code: 1
Last 500 characters of output:
nd_handle_errors
    self.run()
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 54, in run
    self.clean()
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 81, in clean
    step.run()
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/buildsteps.py", line 101, in run
    os.chdir(self._tool._scm.checkout_root)
AttributeError: 'NoneType' object has no attribute 'checkout_root'
Comment 4 Darin Fisher (:fishd, Google) 2009-12-09 10:22:36 PST 
Landed as http://trac.webkit.org/changeset/51904
Comment 5 Eric Seidel (no email) 2009-12-09 11:36:55 PST 
Sorry for the noise.  Adam believes to have fixed the issue.  I've restarted the commit bot.