Bug 322829 – LINKER: cmake syntax does not seem to be compatible with PlayStation port

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

As reported on slack thread https://webkit.slack.com/archives/CU64U6FDW/p1787850185015339

FAILED: bin/libWebKit.prx lib/libWebKit_stub_weak.a
C:\Windows\system32\cmd.exe /C "cd . && C:\ps\sdk\host_tools\bin\prospero-lld.exe -L"C:/PS/sdk/../internal/target/lib"   --prx-stub-output-dir=C:/BW/PlayStation-Build-EWS/build/WebKitBuild/Release/lib -Xlinker --no-undefined -Xlinker --gc-sections -Xlinker --disable-new-dtags C:/playstationrequirements/lib/libdl.a -Wl,--wrap=dlopen -Wl,--wrap=dlclose -Wl,--wrap=dlsym -Wl,--wrap=dlerror -Wl,--wrap=dladdr -Xlinker --wrap=mmap @C:/BW/PlayStation-Build-EWS/build/WebKitBuild/Release/Source/WebKit/CMakeFiles/WebKitUIProcess.dir/Release/objects.rsp @C:/BW/PlayStation-Build-EWS/build/WebKitBuild/Release/Source/WebKit/CMakeFiles/WebKitWebProcess.dir/Release/objects.rsp @C:/BW/PlayStation-Build-EWS/build/WebKitBuild/Release/Source/WebKit/CMakeFiles/WebKitGPUProcess.dir/Release/objects.rsp @C:/BW/PlayStation-Build-EWS/build/WebKitBuild/Release/Source/WebKit/CMakeFiles/WebKitNetworkProcess.dir/Release/objects.rsp @C:/BW/PlayStation-Build-EWS/build/WebKitBuild/Release/Source/WebKit/CMakeFiles/WebKitShared.dir/Release/objects.rsp -o bin\libWebKit.prx --oformat=prx --start-group @CMakeFiles\WebKit.rsp --end-group && C:\Windows\system32\cmd.exe /C "cd /D C:\BW\PlayStation-Build-EWS\build\WebKitBuild\Release\Source\WebKit && C:\ps\orbis_psm\psm\sdk\psm-sdk\tools\python\python.exe C:/ps/internal/host_tools/bin/make_self.py -e C:/BW/PlayStation-Build-EWS/build/WebKitBuild/Release/bin/libWebKit.prx -s C:/BW/PlayStation-Build-EWS/build/WebKitBuild/Release/bin/libWebKit.sprx -i prx_system""
prospero-lld: error: unknown argument '-Xlinker'

prospero-lld: error: unknown argument '-Xlinker'

prospero-lld: error: unknown argument '-Xlinker'

prospero-lld: error: unknown argument '-Xlinker'

First failed build: 319913@main, last green build: 319912@main


I'm looking into this. Raising a bug so I've got a bug number to reference in comments.

Pull request: https://github.com/WebKit/WebKit/pull/72693

The better fix here is to set CMAKE_<LANG>_LINKER_WRAPPER_FLAG to the right value to ask `prospero-lld.exe` to pass linker flags through to the linker.

However, `prospero-lld.exe` _is_ the linker, so it appears as though the Playstation port is deviating from the normal CMake behavior of using the compiler to request linking. Instead, CMake it invoking the linker directly. Perhaps somewhere we're setting `CMAKE_CXX_LINK_SHARED_LIBRARY` to give a different linking command-line entirely.

So, setting CMAKE_<LANG>_LINKER_WRAPPER_FLAG to "" _might_ work. But without knowing exactly how the PS port linking arrangements are structured, I think the hacky workaround in the above PR might be the better bet short-term.

This should probably be assigned to Stephen Szabo for when he returns.

The initial attempt failed because it obviously expected to see -Wl, so I'm trying a new approach of simply setting CMAKE_<LANG>_LINKER_WRAPPER_FLAG to -Wl. We'll see if that works. Otherwise I'll go back to the original "partial revert on PlayStation platform only" but using -Wl.

[EWS]

Committed 320036@main (0c7b760ec659): <https://commits.webkit.org/320036@main>

Reviewed commits have been landed. Closing PR #72693 and removing active labels.