WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
32279
composited layers are sometimes clipped
https://bugs.webkit.org/show_bug.cgi?id=32279
Summary
composited layers are sometimes clipped
Chris Marrin
Reported
2009-12-08 11:20:37 PST
If you open a page with a composited layer taller than the current window and scroll, the layer will be clipped.
Attachments
Patch
(5.81 KB, patch)
2010-01-15 17:26 PST
,
Chris Marrin
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Marrin
Comment 1
2010-01-15 17:26:58 PST
Created
attachment 46720
[details]
Patch
WebKit Review Bot
Comment 2
2010-01-15 17:32:19 PST
Attachment 46720
[details]
did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp:231: Should have a space between // and comment [whitespace/comments] [4] WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp:232: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 2
Darin Adler
Comment 3
2010-01-16 11:08:10 PST
Comment on
attachment 46720
[details]
Patch
> + //m_rootLayer->setAnchorPoint(CGPointMake(0, 1)); > + //CGPoint pos = m_rootLayer->position();
You should remove this commented-out code. Unless it's needed. While I'm not as familiar with this code as some, and there's no regression testing here, the patch looks fine otherwise. Please remove the commented-out code. And if you think someone else (Simon) should review this, feel free to change back from review+ to review?.
Chris Marrin
Comment 4
2010-01-18 10:50:47 PST
Got rid of comments as per Darin's comment. Landed in
http://trac.webkit.org/changeset/53415
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug