Bug 32279 - composited layers are sometimes clipped
Summary: composited layers are sometimes clipped
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Chris Marrin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-08 11:20 PST by Chris Marrin
Modified: 2010-01-18 10:50 PST (History)
2 users (show)

See Also:


Attachments
Patch (5.81 KB, patch)
2010-01-15 17:26 PST, Chris Marrin
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2009-12-08 11:20:37 PST
If you open a page with a composited layer taller than the current window and scroll, the layer will be clipped.
Comment 1 Chris Marrin 2010-01-15 17:26:58 PST
Created attachment 46720 [details]
Patch
Comment 2 WebKit Review Bot 2010-01-15 17:32:19 PST
Attachment 46720 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp:231:  Should have a space between // and comment  [whitespace/comments] [4]
WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp:232:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 2
Comment 3 Darin Adler 2010-01-16 11:08:10 PST
Comment on attachment 46720 [details]
Patch

> +    //m_rootLayer->setAnchorPoint(CGPointMake(0, 1));
> +    //CGPoint pos = m_rootLayer->position();

You should remove this commented-out code. Unless it's needed.

While I'm not as familiar with this code as some, and there's no regression testing here, the patch looks fine otherwise. Please remove the commented-out code.

And if you think someone else (Simon) should review this, feel free to change back from review+ to review?.
Comment 4 Chris Marrin 2010-01-18 10:50:47 PST
Got rid of comments as per Darin's comment.

Landed in http://trac.webkit.org/changeset/53415