Bug 32274 - Fails to build on FreeBSD, IA64, and Alpha.
Summary: Fails to build on FreeBSD, IA64, and Alpha.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-08 07:31 PST by Gustavo Noronha (kov)
Modified: 2009-12-08 14:45 PST (History)
2 users (show)

See Also:

Attachments
proposed fix (1.81 KB, patch)
2009-12-08 07:32 PST, Gustavo Noronha (kov) 		darin: review-
gustavo: commit-queue-
Details | Formatted Diff | Diff
proposed fix - second try (1.81 KB, patch)
2009-12-08 09:35 PST, Gustavo Noronha (kov) 		darin: review+
gustavo: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2009-12-08 07:31:55 PST 
Summary says it all, these platforms fail to build WebKit.
Comment 1 Gustavo Noronha (kov) 2009-12-08 07:32:33 PST 
Created attachment 44470 [details]
proposed fix
Comment 2 WebKit Review Bot 2009-12-08 07:37:33 PST 
style-queue ran check-webkit-style on attachment 44470 [details] without any errors.
Comment 3 Darin Adler 2009-12-08 07:45:23 PST 
Comment on attachment 44470 [details]
proposed fix

> -#if PLATFORM(X86_64) && (PLATFORM(DARWIN) || PLATFORM(LINUX) || PLATFORM(WIN_OS))
> +#if (PLATFORM(X86_64) && PLATFORM(UNIX)) || PLATFORM(IA64) || PLATFORM(ALPHA) || PLATFORM(WIN_OS)
>  #define WTF_USE_JSVALUE64 1

This will incorrectly define WTF_USE_JSVALUE64 on 32-bit WIN_OS builds.
Comment 4 Gustavo Noronha (kov) 2009-12-08 09:35:42 PST 
Created attachment 44475 [details]
proposed fix - second try

Good catch! Second try.
Comment 5 Gustavo Noronha (kov) 2009-12-08 14:45:03 PST 
Landed as 51871.