Bug 32266 - WebSocket must allow space (U+0020) in sub protocol name
Summary: WebSocket must allow space (U+0020) in sub protocol name
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-08 00:34 PST by Fumitoshi Ukai
Modified: 2009-12-09 11:21 PST (History)
2 users (show)

See Also:

Attachments
WebSocket allow space (U+0020) in sub protocol name. (7.40 KB, patch)
2009-12-08 00:48 PST, Fumitoshi Ukai 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fumitoshi Ukai 2009-12-08 00:34:41 PST 
Latest WebSocket API / protocol spec draft allow space (U+0020) in sub protocol name.
Comment 1 Fumitoshi Ukai 2009-12-08 00:48:41 PST 
Created attachment 44461 [details]
WebSocket allow space (U+0020) in sub protocol name.
Comment 2 Fumitoshi Ukai 2009-12-08 00:50:08 PST 
(In reply to comment #1)
> Created an attachment (id=44461) [details]
> WebSocket allow space (U+0020) in sub protocol name.

This patch requires new version of pywebsocket r134 or later.
Comment 3 WebKit Review Bot 2009-12-08 00:50:57 PST 
style-queue ran check-webkit-style on attachment 44461 [details] without any errors.
Comment 4 Darin Adler 2009-12-08 07:02:02 PST 
Comment on attachment 44461 [details]
WebSocket allow space (U+0020) in sub protocol name.

> -// Fails if protocol containns an character greater than U+007F.
> +// Fails if protocol containns an character greater than U+007E.

Typo here "containns".
Comment 5 Fumitoshi Ukai 2009-12-08 19:40:06 PST 
Committed r51886: <http://trac.webkit.org/changeset/51886>
Comment 6 Alexey Proskuryakov 2009-12-09 08:34:39 PST 
I'm confused - how can the sub-protocol-with-space test work, if corresponding server side fixes aren't made yet (see bug 32249 that has fixes for _validate_protocol)?
Comment 7 Alexey Proskuryakov 2009-12-09 11:21:09 PST 
I now read ChangeLog comments, and am no longer confused. Sorry for the noise!