Bug 32260 - DOMHTMLInputElement needs getter to match setAutofilled
Summary: DOMHTMLInputElement needs getter to match setAutofilled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: John Sullivan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-07 17:40 PST by John Sullivan
Modified: 2009-12-08 07:51 PST (History)
1 user (show)

See Also:


Attachments
Patch to add isAutofilled to Mac and Windows WebKit (1.62 KB, patch)
2009-12-07 17:41 PST, John Sullivan
sullivan: review-
Details | Formatted Diff | Diff
Patch to add isAutofilled to Mac and Windows WebKit (4.00 KB, patch)
2009-12-07 17:46 PST, John Sullivan
adachan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Sullivan 2009-12-07 17:40:24 PST
DOMHTMLInputElement includes a setter, setAutofilled, for which there is no corresponding getter. This getter would be convenient in some code I'm working on.
Comment 1 John Sullivan 2009-12-07 17:41:31 PST
Created attachment 44453 [details]
Patch to add isAutofilled to Mac and Windows WebKit
Comment 2 John Sullivan 2009-12-07 17:43:35 PST
Comment on attachment 44453 [details]
Patch to add isAutofilled to Mac and Windows WebKit

D'oh! That was the wrong patch. Please ignore.
Comment 3 John Sullivan 2009-12-07 17:46:00 PST
Created attachment 44454 [details]
Patch to add isAutofilled to Mac and Windows WebKit
Comment 4 WebKit Review Bot 2009-12-07 17:50:35 PST
style-queue ran check-webkit-style on attachment 44454 [details] without any errors.
Comment 5 Ada Chan 2009-12-07 17:57:07 PST
Comment on attachment 44454 [details]
Patch to add isAutofilled to Mac and Windows WebKit


> +HRESULT STDMETHODCALLTYPE DOMHTMLInputElement::isAutofilled(
> +    /* [retval][out] */ BOOL* result)
> +{
> +    ASSERT(m_element && m_element->hasTagName(inputTag));

Maybe separate the ASSERT into two lines?


> +    HTMLInputElement* inputElement = static_cast<HTMLInputElement*>(m_element);
> +    *result = inputElement->isAutofilled() ? TRUE : FALSE;
> +    return S_OK;
> +}
> +

r=me
Comment 6 John Sullivan 2009-12-08 07:09:02 PST
Fixed in r51850.
Comment 7 John Sullivan 2009-12-08 07:51:40 PST
Oops, I forgot to split apart the assertion as suggested in the review. I'll do that as a separate patch.