Bug 32254 - Implement property enumerator for V8NPObject
Summary: Implement property enumerator for V8NPObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-07 15:30 PST by Victor Wang
Modified: 2009-12-07 20:33 PST (History)
3 users (show)

See Also:


Attachments
Proposed Patch (3.96 KB, patch)
2009-12-07 15:42 PST, Victor Wang
no flags Details | Formatted Diff | Diff
Proposed Patch + Style fixes (5.56 KB, patch)
2009-12-07 16:16 PST, Victor Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Wang 2009-12-07 15:30:26 PST
Need to implement NamedPropertyEnumerator and IndexedPropertyEnumerator for V8NPObject so it can be enumerated. This is one reason why the following layout test fails in Chromium:
LayoutTests/plugins/netscape-enumerate.html
Comment 1 Victor Wang 2009-12-07 15:42:41 PST
Created attachment 44439 [details]
Proposed Patch
Comment 2 WebKit Review Bot 2009-12-07 15:46:02 PST
style-queue ran check-webkit-style on attachment 44439 [details] without any errors.
Comment 3 Victor Wang 2009-12-07 16:16:33 PST
Created attachment 44441 [details]
Proposed Patch + Style fixes

Some existing code do not meet the Webkit style guidelines, the new patch fixes them.
Comment 4 WebKit Review Bot 2009-12-07 16:16:58 PST
style-queue ran check-webkit-style on attachment 44441 [details] without any errors.
Comment 5 Dimitri Glazkov (Google) 2009-12-07 20:18:34 PST
Comment on attachment 44441 [details]
Proposed Patch + Style fixes

Looks great, thanks for working on this.
Comment 6 WebKit Commit Bot 2009-12-07 20:33:43 PST
Comment on attachment 44441 [details]
Proposed Patch + Style fixes

Clearing flags on attachment: 44441

Committed r51831: <http://trac.webkit.org/changeset/51831>
Comment 7 WebKit Commit Bot 2009-12-07 20:33:49 PST
All reviewed patches have been landed.  Closing bug.