RESOLVED FIXED 32254
Implement property enumerator for V8NPObject
https://bugs.webkit.org/show_bug.cgi?id=32254
Summary Implement property enumerator for V8NPObject
Victor Wang
Reported 2009-12-07 15:30:26 PST
Need to implement NamedPropertyEnumerator and IndexedPropertyEnumerator for V8NPObject so it can be enumerated. This is one reason why the following layout test fails in Chromium: LayoutTests/plugins/netscape-enumerate.html
Attachments
Proposed Patch (3.96 KB, patch)
2009-12-07 15:42 PST, Victor Wang
no flags
Proposed Patch + Style fixes (5.56 KB, patch)
2009-12-07 16:16 PST, Victor Wang
no flags
Victor Wang
Comment 1 2009-12-07 15:42:41 PST
Created attachment 44439 [details] Proposed Patch
WebKit Review Bot
Comment 2 2009-12-07 15:46:02 PST
style-queue ran check-webkit-style on attachment 44439 [details] without any errors.
Victor Wang
Comment 3 2009-12-07 16:16:33 PST
Created attachment 44441 [details] Proposed Patch + Style fixes Some existing code do not meet the Webkit style guidelines, the new patch fixes them.
WebKit Review Bot
Comment 4 2009-12-07 16:16:58 PST
style-queue ran check-webkit-style on attachment 44441 [details] without any errors.
Dimitri Glazkov (Google)
Comment 5 2009-12-07 20:18:34 PST
Comment on attachment 44441 [details] Proposed Patch + Style fixes Looks great, thanks for working on this.
WebKit Commit Bot
Comment 6 2009-12-07 20:33:43 PST
Comment on attachment 44441 [details] Proposed Patch + Style fixes Clearing flags on attachment: 44441 Committed r51831: <http://trac.webkit.org/changeset/51831>
WebKit Commit Bot
Comment 7 2009-12-07 20:33:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.