Bug 32253 - Consider changing WebSocket test server root to match Apache
Summary: Consider changing WebSocket test server root to match Apache
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-07 15:16 PST by Alexey Proskuryakov
Modified: 2016-05-18 21:33 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2009-12-07 15:16:11 PST 
For WebKit HTTP tests, the root is LayoutTests/http/tests, but for WebSocket ones, it's LayoutTests/. Is there a reason for such a difference? It's somewhat confusing, and makes one use longer paths in tests.
Comment 1 Yuzo Fujishima 2009-12-07 17:42:40 PST 
The root has been chosen such that LayoutTests/fast/js/resources/*.js are
accessible from Web Socket tests.

As an alternative, I considered using a symbolic link from the websocket directory
but decided otherwise, because the SVN's handling of symbolic link on Windows
could confuse developers.

Yuzo
Comment 2 Alexey Proskuryakov 2009-12-08 14:46:47 PST 
Sharing resources is good, but maybe if would still be better for WebSocket to have its own copy of the files. Since WebSocket tests are all async - unlike most JS tests - this could help us make an easier to use test harness for those. Currently, there is a lot of copy/paste code needed in every test.