WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
32253
Consider changing WebSocket test server root to match Apache
https://bugs.webkit.org/show_bug.cgi?id=32253
Summary
Consider changing WebSocket test server root to match Apache
Alexey Proskuryakov
Reported
2009-12-07 15:16:11 PST
For WebKit HTTP tests, the root is LayoutTests/http/tests, but for WebSocket ones, it's LayoutTests/. Is there a reason for such a difference? It's somewhat confusing, and makes one use longer paths in tests.
Attachments
Add attachment
proposed patch, testcase, etc.
Yuzo Fujishima
Comment 1
2009-12-07 17:42:40 PST
The root has been chosen such that LayoutTests/fast/js/resources/*.js are accessible from Web Socket tests. As an alternative, I considered using a symbolic link from the websocket directory but decided otherwise, because the SVN's handling of symbolic link on Windows could confuse developers. Yuzo
Alexey Proskuryakov
Comment 2
2009-12-08 14:46:47 PST
Sharing resources is good, but maybe if would still be better for WebSocket to have its own copy of the files. Since WebSocket tests are all async - unlike most JS tests - this could help us make an easier to use test harness for those. Currently, there is a lot of copy/paste code needed in every test.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug