As AndroidWebHistoryBridge holds a dumb pointer of HistoryItem and HistoryItem holds a RefPtr of AndroidWebHistoryBridge, the dumb pointer needs to be cleared when HistoryItem is deleted to avoid potential crash.
Created attachment 44436 [details] proposed patch
Comment on attachment 44436 [details] proposed patch The tab in AndroidWebHistoryBridge.h will prevent this from being landed as is. Although WebKit has no explicit wrapping rule, it mgiht make sense to wrap the txt in the ChangeLog at some point. It feels strange that HistoryItem.cpp has to have an ANDROID ifdef, but maybe that's the design that you and Brady agreed on? r- for the tab.
Created attachment 44448 [details] new patch according to the comment. Fix the tab. Add line break in the ChangeLog. The pattern used in HistoryItem is following the existing model.
Comment on attachment 44448 [details] new patch according to the comment. Rejecting patch 44448 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Darin Adler', '--force']" exit_code: 1 patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/history/HistoryItem.cpp Hunk #1 FAILED at 102. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/history/HistoryItem.cpp.rej patching file WebCore/history/android/AndroidWebHistoryBridge.h
This is a straightforward merge fix, I'll land manually.
Landed as r51980.