Bug 32247 – [GTK] Doesn't respect Content-Disposition for downloads, and provides no way for apps to do that

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Gustavo Noronha (kov)]

Currently, when a server sends a response with Content-Disposition, we are not respecting it, and we give no means for the application to decided, during the mime type policy check, if it wants to perform a download based on that header. This is a rather severe problem for some users, because it makes us unable to work correctly when the 'Download' link in attachments webkit is able to render itself is clicked in GMail, for instance.

[Gustavo Noronha (kov)]

Created attachment 44433 [details]
proposed fix

[Gustavo Noronha (kov)]

Xan? Jan? =)

[WebKit Review Bot]

Attachment 44433 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/gtk/tests/testwebframe.c:158:  test_webkit_web_frame_response is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit/gtk/tests/testwebframe.c:160:  Declaration has space between * and variable name in WebKitWebFrame* frame  [whitespace/declaration] [3]
WebKit/gtk/tests/testwebframe.c:161:  Declaration has space between * and variable name in WebKitNetworkResponse* response  [whitespace/declaration] [3]
WebKit/gtk/webkit/webkitwebframe.cpp:1158:  webkit_web_frame_get_network_response is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit/gtk/webkit/webkitwebframe.cpp:1162:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/gtk/webkit/webkitwebframe.cpp:1166:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/gtk/webkit/webkitwebframe.h:176:  Extra space before ( in function call  [whitespace/parens] [4]
WebKit/gtk/tests/testmimehandling.c:109:  Declaration has space between * and variable name in WebKitNetworkResponse* response  [whitespace/declaration] [3]
WebKit/gtk/tests/testmimehandling.c:110:  Declaration has space between * and variable name in SoupMessage* message  [whitespace/declaration] [3]
WebKit/gtk/tests/testmimehandling.c:111:  Declaration has space between * and variable name in char* disposition  [whitespace/declaration] [3]
Total errors found: 10

[Xan Lopez]

Comment on attachment 44433 [details]
proposed fix

Nice!

[Gustavo Noronha (kov)]

Landed as r51825.