Bug 32236 - wx port lacks plugin support on Mac
: wx port lacks plugin support on Mac
Status: RESOLVED FIXED
: WebKit
WebKit wx
: 528+ (Nightly build)
: PC Mac OS X 10.6
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-12-07 12:54 PST by
Modified: 2009-12-08 16:54 PST (History)


Attachments
add support for plugins on wxMac (19.27 KB, patch)
2009-12-07 12:54 PST, Kevin Watters
no flags Review Patch | Details | Formatted Diff | Diff
fixes style issues (19.28 KB, application/octet-stream)
2009-12-08 08:09 PST, Kevin Watters
kevino: review+
kevino: commit‑queue-
Details


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-12-07 12:54:43 PST
Created an attachment (id=44425) [details]
add support for plugins on wxMac

The Mac wx port needs several small fixes to support plugins.
------- Comment #1 From 2009-12-07 12:55:05 PST -------
Attachment 44425 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/cf/BinaryPropertyList.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/FileSystem.h:48:  "CoreFoundation/CFBundle.h" already included at WebCore/platform/FileSystem.h:43  [build/include] [4]
WebCore/plugins/wx/PluginDataWx.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/plugins/wx/PluginDataWx.cpp:39:  Declaration has space between type name and * in PluginDatabase *db  [whitespace/declaration] [3]
WebCore/platform/wx/FileSystemWx.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/wx/FileSystemWx.cpp:145:  This { should be at the end of the previous line  [whitespace/braces] [4]
WebCore/platform/wx/FileSystemWx.cpp:186:  Extra space before )  [whitespace/parens] [2]
WebCore/plugins/mac/PluginViewMac.cpp:207:  One line control clauses should not use braces.  [whitespace/braces] [4]
WebCore/plugins/mac/PluginViewMac.cpp:747:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
WebCore/plugins/mac/PluginViewMac.cpp:749:  Extra space after ( in function call  [whitespace/parens] [4]
WebCore/plugins/mac/PluginViewMac.cpp:749:  Extra space before )  [whitespace/parens] [2]
WebCore/plugins/mac/PluginViewMac.cpp:749:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
WebCore/plugins/mac/PluginViewMac.cpp:750:  Extra space after ( in function call  [whitespace/parens] [4]
WebCore/plugins/mac/PluginViewMac.cpp:750:  Extra space before )  [whitespace/parens] [2]
WebCore/plugins/mac/PluginViewMac.cpp:750:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
WebCore/plugins/mac/PluginViewMac.cpp:752:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Total errors found: 16
------- Comment #2 From 2009-12-08 08:09:24 PST -------
Created an attachment (id=44472) [details]
fixes style issues

Including wx/wx.h first fails the style checker, but is correct based on wx port conventions.
------- Comment #3 From 2009-12-08 08:13:47 PST -------
Attachment 44472 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/wx/FileSystemWx.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1
------- Comment #4 From 2009-12-08 16:54:15 PST -------
Landed in r51880, thanks!