RESOLVED FIXED 32225
[check-webkit-style] S_OK is a fine identifier 
https://bugs.webkit.org/show_bug.cgi?id=32225
Summary [check-webkit-style] S_OK is a fine identifier
Adam Barth
Reported 2009-12-07 09:14:41 PST
WebCore/platform/text/wince/TextCodecWince.cpp:125: S_OK is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] https://bugs.webkit.org/show_bug.cgi?id=32169#c2 That's a false positive.
Attachments
Patch v1 (2.15 KB, patch)
2009-12-07 21:15 PST, Shinichiro Hamaji 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shinichiro Hamaji
Comment 1 2009-12-07 21:15:39 PST
Created attachment 44458 [details] Patch v1
WebKit Review Bot
Comment 2 2009-12-07 21:18:03 PST
style-queue ran check-webkit-style on attachment 44458 [details] without any errors.
Shinichiro Hamaji
Comment 3 2009-12-07 21:20:06 PST
This happened because the style checker considered it is the declaration of S_OK. if (mli && S_OK == mli->EnumCodePages(MIMECONTF_BROWSER, &enumInterface)) { Note that we should warn about the following statement. if (int & S_OK = intValue) { My patch checks the character after the first '='.
Shinichiro Hamaji
Comment 4 2009-12-07 21:58:51 PST
Comment on attachment 44458 [details] Patch v1 Clearing flags on attachment: 44458 Committed r51835: <http://trac.webkit.org/changeset/51835>
Shinichiro Hamaji
Comment 5 2009-12-07 21:59:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.