With Qt 4.6 trunk and Webkit trunk, the autotest "tst_QWebPage::requestCache()" is failing.
Created attachment 44466 [details] Proposed fix The behavior wrt cache policy on backward navigation was broken by a typo in http://trac.webkit.org/changeset/51644 See also https://bugs.webkit.org/show_bug.cgi?id=32052
Comment on attachment 44466 [details] Proposed fix Good job. I change the review flag to ?.
style-queue ran check-webkit-style on attachment 44466 [details] without any errors.
This bug is not qt-specific if it's in common code. I've CC'd the authors of the original change.
Comment on attachment 44466 [details] Proposed fix It's a shame that we didn't have LayoutTests to catch this regression. It's awesome that some other automatic testing caught it. It's a HUGE shame that this other automated testing isn't cross platform and doesn't run on a bot that is part of the main LayoutTest infrastructure that people monitor at build.webkit.org. Is there any particular reason why such testing can't be integrated into the main project? r+ anyways.
I think Brady meant to set r+ on the patch.
And I thought I did.
Comment on attachment 44466 [details] Proposed fix Clearing flags on attachment: 44466 Committed r51924: <http://trac.webkit.org/changeset/51924>
All reviewed patches have been landed. Closing bug.
(In reply to comment #5) > It's a shame that we didn't have LayoutTests to catch this regression. > It's awesome that some other automatic testing caught it. > It's a HUGE shame that this other automated testing isn't cross platform and > doesn't run on a bot that is part of the main LayoutTest infrastructure that > people monitor at build.webkit.org. The Qt autotest are C++ tests for the Qt APIs, they are currently run in the Qt infrastructure, separated from webkit. There is work being done to run the webkit's autotests as a layout test on the Qt bot. Just be patient, this is coming.