We need to abstract our steps so we can sequence them more easily.
Created attachment 44391 [details] Patch
Created attachment 44514 [details] Patch
Attachment 44514 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Traceback (most recent call last): File "WebKitTools/Scripts/check-webkit-style", line 40, in <module> from modules.scm import detect_scm_system File "/home/abarth/git/webkit-style/WebKitTools/Scripts/modules/scm.py", line 38, in <module> from modules.executive import run_command, ScriptError, default_error_handler, ignore_error ImportError: No module named executive
Comment on attachment 44514 [details] Patch Sigh. I guess I'll trust you on this one.
Committed r51889: <http://trac.webkit.org/changeset/51889>
Comment on attachment 44514 [details] Patch Rejecting patch 44514 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 2 Last 500 characters of output: s/processutils.py |deleted file mode 100644 |index 7a681bf..0000000 |--- WebKitTools/Scripts/modules/processutils.py |+++ WebKitTools/Scripts/modules/processutils.py -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored fatal: pathspec 'WebKitTools/Scripts/modules/processutils.py' did not match any files Failed to git rm --force WebKitTools/Scripts/modules/processutils.py. at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply line 487, <> line 806.