Bug 32212 - [bzt] Implement abstract Steps
Summary: [bzt] Implement abstract Steps
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-12-07 00:30 PST by Adam Barth
Modified: 2009-12-09 00:21 PST (History)
2 users (show)

See Also:

Patch (23.08 KB, patch)
2009-12-07 00:31 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (33.78 KB, patch)
2009-12-09 00:04 PST, Adam Barth
eric: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-12-07 00:30:07 PST
We need to abstract our steps so we can sequence them more easily.
Comment 1 Adam Barth 2009-12-07 00:31:02 PST
Created attachment 44391 [details]
Comment 2 Adam Barth 2009-12-09 00:04:34 PST
Created attachment 44514 [details]
Comment 3 WebKit Review Bot 2009-12-09 00:09:04 PST
Attachment 44514 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Traceback (most recent call last):
  File "WebKitTools/Scripts/check-webkit-style", line 40, in <module>
    from modules.scm import detect_scm_system
  File "/home/abarth/git/webkit-style/WebKitTools/Scripts/modules/scm.py", line 38, in <module>
    from modules.executive import run_command, ScriptError, default_error_handler, ignore_error
ImportError: No module named executive
Comment 4 Eric Seidel (no email) 2009-12-09 00:16:42 PST
Comment on attachment 44514 [details]

Sigh.  I guess I'll trust you on this one.
Comment 5 Adam Barth 2009-12-09 00:21:06 PST
Committed r51889: <http://trac.webkit.org/changeset/51889>
Comment 6 WebKit Commit Bot 2009-12-09 00:21:28 PST
Comment on attachment 44514 [details]

Rejecting patch 44514 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 2
Last 500 characters of output:
|deleted file mode 100644
|index 7a681bf..0000000
|--- WebKitTools/Scripts/modules/processutils.py
|+++ WebKitTools/Scripts/modules/processutils.py
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
fatal: pathspec 'WebKitTools/Scripts/modules/processutils.py' did not match any files
Failed to git rm --force WebKitTools/Scripts/modules/processutils.py. at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply line 487, <> line 806.