Bug 32192 - [check-webkit-style] False positive for camel case of JSC op codes
Summary: [check-webkit-style] False positive for camel case of JSC op codes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-06 08:44 PST by Adam Barth
Modified: 2009-12-08 10:59 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.84 KB, patch)
2009-12-07 18:07 PST, David Levin
no flags Details | Formatted Diff | Diff
Patch (2.84 KB, patch)
2009-12-07 18:09 PST, David Levin
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-12-06 08:44:02 PST
According to <https://bugs.webkit.org/show_bug.cgi?id=32190#c7>, check-webkit-style should have an exception for the camelCase naming rule for JavaScript OP codes.  Mjs suggests that we white list variables with the substring "_op_", possibly only in the JavaScriptCore directory.
Comment 1 David Levin 2009-12-07 18:07:53 PST
Created attachment 44456 [details]
Patch
Comment 2 David Levin 2009-12-07 18:09:18 PST
Created attachment 44457 [details]
Patch
Comment 3 WebKit Review Bot 2009-12-07 18:11:37 PST
style-queue ran check-webkit-style on attachment 44457 [details] without any errors.
Comment 4 Adam Barth 2009-12-08 10:18:55 PST
Comment on attachment 44457 [details]
Patch

Thanks!
Comment 5 David Levin 2009-12-08 10:59:02 PST
Committed as http://trac.webkit.org/changeset/51866