WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
32192
[check-webkit-style] False positive for camel case of JSC op codes
https://bugs.webkit.org/show_bug.cgi?id=32192
Summary
[check-webkit-style] False positive for camel case of JSC op codes
Adam Barth
Reported
2009-12-06 08:44:02 PST
According to <
https://bugs.webkit.org/show_bug.cgi?id=32190#c7
>, check-webkit-style should have an exception for the camelCase naming rule for JavaScript OP codes. Mjs suggests that we white list variables with the substring "_op_", possibly only in the JavaScriptCore directory.
Attachments
Patch
(2.84 KB, patch)
2009-12-07 18:07 PST
,
David Levin
no flags
Details
Formatted Diff
Diff
Patch
(2.84 KB, patch)
2009-12-07 18:09 PST
,
David Levin
abarth
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
David Levin
Comment 1
2009-12-07 18:07:53 PST
Created
attachment 44456
[details]
Patch
David Levin
Comment 2
2009-12-07 18:09:18 PST
Created
attachment 44457
[details]
Patch
WebKit Review Bot
Comment 3
2009-12-07 18:11:37 PST
style-queue ran check-webkit-style on
attachment 44457
[details]
without any errors.
Adam Barth
Comment 4
2009-12-08 10:18:55 PST
Comment on
attachment 44457
[details]
Patch Thanks!
David Levin
Comment 5
2009-12-08 10:59:02 PST
Committed as
http://trac.webkit.org/changeset/51866
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug