Created attachment 44353 [details] proposed patch We have some API tests we name 'unittests'. It's important to have them running automatically for each commit like we do with layout tests. I'm attaching a patch to implement this - the run-gtk-tests script is not very sophisticated, but should be enough for our current needs.
style-queue ran check-webkit-style on attachment 44353 [details] without any errors.
Comment on attachment 44353 [details] proposed patch We have shared code for how to get the configuration directory in webkitdirs.pm. I think we should re-use that here. Meaning we should just make run-gtk-tests a perl script. Unfortunately we don't have any equivalent detection code for python or I would suggest we write this in python instead. :) In general the code looks OK. I'm not really an expert on the internals of buildbot. There might be a more concise way to write parts of the class. No need to call bash directly, or? + command = ["bash", "./WebKitTools/Scripts/run-gtk-tests", WithProperties("--%(configuration)s")] r- for not re-using existing configuration directory detection logic.
Thanks for the review! (In reply to comment #2) > (From update of attachment 44353 [details]) > We have shared code for how to get the configuration directory in > webkitdirs.pm. I think we should re-use that here. Meaning we should just > make run-gtk-tests a perl script. Unfortunately we don't have any equivalent > detection code for python or I would suggest we write this in python instead. > :) OK; I was kind of avoiding this, but I think it makes sense to keep this kind of logic in a centralized place. > No need to call bash directly, or? > + command = ["bash", "./WebKitTools/Scripts/run-gtk-tests", > WithProperties("--%(configuration)s")] That's to keep consistency. Perl also theoretically does not need to be called directly, but all commands include it explicitely.
bug 33432 is also very similar.
Created attachment 48245 [details] Run GTK+ API tests Addresses the concerns raised by Eric.
Comment on attachment 48245 [details] Run GTK+ API tests Looks OK to me. It's actually now possible to write this sort of thing in python now that we've added "webkit-build-directory" which is able to let non-perl scripts access these sorts of things. :) Anyway, this looks fine.
Landed as r54956.