Bug 32181 - Move update-webkit into BuildSteps
Summary: Move update-webkit into BuildSteps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 27162
Blocks: 32182
  Show dependency tree / graph
 
Reported: 2009-12-04 19:01 PST by Adam Barth
Modified: 2009-12-05 13:54 PST (History)
2 users (show)

See Also:

Attachments
Patch (4.98 KB, patch)
2009-12-04 19:02 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (5.27 KB, patch)
2009-12-04 19:02 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-12-04 19:01:45 PST 
We need to move update-webkit out of SCM.py because SCM isn't supposed to know that WebKit exists.  The proper place for the knowledge of the existence of update-webkit is in WebKitPort because some ports have specialized update scripts (analogous to build-webkit).
Comment 1 Adam Barth 2009-12-04 19:02:19 PST 
Created attachment 44343 [details]
Patch
Comment 2 Adam Barth 2009-12-04 19:02:54 PST 
Created attachment 44344 [details]
Patch
Comment 3 WebKit Review Bot 2009-12-04 19:05:28 PST 
style-queue ran check-webkit-style on attachment 44344 [details] without any errors.
Comment 4 Eric Seidel (no email) 2009-12-05 00:36:41 PST 
Comment on attachment 44344 [details]
Patch

Wow.  Yeah, this is way better!

I'll forgive you for lack of test. ;)
Comment 5 Adam Barth 2009-12-05 13:54:47 PST 
Comment on attachment 44344 [details]
Patch

Clearing flags on attachment: 44344

Committed r51729: <http://trac.webkit.org/changeset/51729>
Comment 6 Adam Barth 2009-12-05 13:54:53 PST 
All reviewed patches have been landed.  Closing bug.