Bug 32179 - fixes to build-webkit --chromium
Summary: fixes to build-webkit --chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-04 16:21 PST by Yaar Schnitman
Modified: 2009-12-07 12:17 PST (History)
5 users (show)

See Also:

Attachments
fixes (6.94 KB, patch)
2009-12-04 16:23 PST, Yaar Schnitman 		no flags Details | Formatted Diff | Diff
fixes (6.50 KB, patch)
2009-12-04 17:31 PST, Yaar Schnitman 		no flags Details | Formatted Diff | Diff
Patch with typo fix (6.47 KB, patch)
2009-12-07 10:38 PST, Yaar Schnitman 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yaar Schnitman 2009-12-04 16:21:37 PST 
1. Changes to support running build-webkit outside of cygwin on windows (Chromium is bundled with cygwin).  
2. Generation and execution of linux make file.
Comment 1 Yaar Schnitman 2009-12-04 16:23:43 PST 
Created attachment 44339 [details]
fixes
Comment 2 Dimitri Glazkov (Google) 2009-12-04 16:30:15 PST 
Comment on attachment 44339 [details]
fixes

seems reasonable.
Comment 3 WebKit Commit Bot 2009-12-04 17:12:28 PST 
Comment on attachment 44339 [details]
fixes

Rejecting patch 44339 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Dimitri Glazkov', '--force']" exit_code: 1
patching file WebKit/chromium/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/chromium/DEPS
Hunk #1 succeeded at 143 (offset 4 lines).
patching file WebKit/chromium/WebKit.gyp
patching file WebKit/chromium/gyp_webkit
patching file WebKitTools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKitTools/Scripts/webkitdirs.pm
Hunk #1 FAILED at 1037.
1 out of 3 hunks FAILED -- saving rejects to file WebKitTools/Scripts/webkitdirs.pm.rej
Comment 4 Yaar Schnitman 2009-12-04 17:31:07 PST 
Created attachment 44341 [details]
fixes
Comment 5 WebKit Review Bot 2009-12-04 17:33:58 PST 
style-queue ran check-webkit-style on attachment 44341 [details] without any errors.
Comment 6 Eric Seidel (no email) 2009-12-04 17:45:57 PST 
Comment on attachment 44341 [details]
fixes

52             # We can't turn on warnings on Windows and Linux until we're upstream the
5053             # WebKit API.

That comment change is wrong.
"we" or "we've" would work, but "we're" is wrong.

These seem like unrelated changes.  Or at lease could be landed separately.

I'm not sure I understand the need for buildChromiumVisualStudioProject as a fork from buildVisualStudioProject

I'm also not sure if there is code to be shared with buildChromiumMakefile ?
Comment 7 Eric Seidel (no email) 2009-12-07 10:32:40 PST 
Comment on attachment 44341 [details]
fixes

Yaar has convinced me he'll clean up the code duplication at a less "urgent" time.  He can fix the comment on landing.
Comment 8 Yaar Schnitman 2009-12-07 10:38:58 PST 
Created attachment 44420 [details]
Patch with typo fix
Comment 9 WebKit Review Bot 2009-12-07 10:42:13 PST 
style-queue ran check-webkit-style on attachment 44420 [details] without any errors.
Comment 10 WebKit Commit Bot 2009-12-07 12:17:28 PST 
Comment on attachment 44420 [details]
Patch with typo fix

Clearing flags on attachment: 44420

Committed r51788: <http://trac.webkit.org/changeset/51788>
Comment 11 WebKit Commit Bot 2009-12-07 12:17:33 PST 
All reviewed patches have been landed.  Closing bug.