Bug 32179 – fixes to build-webkit --chromium

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Yaar Schnitman]

1. Changes to support running build-webkit outside of cygwin on windows (Chromium is bundled with cygwin).  
2. Generation and execution of linux make file.

[Yaar Schnitman]

Created attachment 44339 [details]
fixes

[Dimitri Glazkov (Google)]

Comment on attachment 44339 [details]
fixes

seems reasonable.

[WebKit Commit Bot]

Comment on attachment 44339 [details]
fixes

Rejecting patch 44339 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Dimitri Glazkov', '--force']" exit_code: 1
patching file WebKit/chromium/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/chromium/DEPS
Hunk #1 succeeded at 143 (offset 4 lines).
patching file WebKit/chromium/WebKit.gyp
patching file WebKit/chromium/gyp_webkit
patching file WebKitTools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKitTools/Scripts/webkitdirs.pm
Hunk #1 FAILED at 1037.
1 out of 3 hunks FAILED -- saving rejects to file WebKitTools/Scripts/webkitdirs.pm.rej

[Yaar Schnitman]

Created attachment 44341 [details]
fixes

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 44341 [details] without any errors.

[Eric Seidel (no email)]

Comment on attachment 44341 [details]
fixes

52             # We can't turn on warnings on Windows and Linux until we're upstream the
5053             # WebKit API.

That comment change is wrong.
"we" or "we've" would work, but "we're" is wrong.

These seem like unrelated changes.  Or at lease could be landed separately.

I'm not sure I understand the need for buildChromiumVisualStudioProject as a fork from buildVisualStudioProject

I'm also not sure if there is code to be shared with buildChromiumMakefile ?

[Eric Seidel (no email)]

Comment on attachment 44341 [details]
fixes

Yaar has convinced me he'll clean up the code duplication at a less "urgent" time.  He can fix the comment on landing.

[Yaar Schnitman]

Created attachment 44420 [details]
Patch with typo fix

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 44420 [details] without any errors.

[WebKit Commit Bot]

Comment on attachment 44420 [details]
Patch with typo fix

Clearing flags on attachment: 44420

Committed r51788: <http://trac.webkit.org/changeset/51788>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.