Bug 32176 – Test that an image's size is valid before reading it.

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[Adam Langley]

Previously, an image that failed to load (m_failed == true) would trigger an assertion failure when WebKit tried to get its size.

[Adam Langley]

Created attachment 44338 [details]
patch

(contains a binary file, so please don't cq+!)

[Darin Adler]

Comment on attachment 44338 [details]
patch

>      // Zero-height images can cause problems for some ports.  If we have an
>      // empty image dimension, just bail.
> -    if (size().isEmpty())
> +    if (isSizeAvailable() && size().isEmpty())
>          return 0;

This changes the logic. If the size is not available, this now continues and creates a native image. But the old code would return 0 if the size was not available. You should reverse the logic.

    if (!isSizeAvailable() || ...

[Adam Langley]

Created attachment 44503 [details]
patch

I originally thought that size() would return random memory in the case that it hadn't been set, but now I notice that it's constructed to 0, 0. So I've changed the logic as suggested.

[Adam Langley]

Created attachment 44504 [details]
patch

Crap. Wrong patch. Corrected.

[Eric Seidel (no email)]

Attachment 44504 [details] was posted by a committer and has review+, assigning to Adam Langley for commit.

[Eric Seidel (no email)]

Comment on attachment 44504 [details]
patch

This can't be cq'd because it's missing the binary data.

[Adam Langley]

r52102

[Eric Seidel (no email)]

This test seems to be (at least recently) crashing on Gtk.