RESOLVED FIXED 32168
[Qt] Add setAllowUniversalAccessFromFileURLs to the LayoutTestController 
https://bugs.webkit.org/show_bug.cgi?id=32168
Summary [Qt] Add setAllowUniversalAccessFromFileURLs to the LayoutTestController
Kenneth Rohde Christiansen
Reported 2009-12-04 12:47:27 PST
Created attachment 44326 [details] Patch Implement the setAllowUniversalAccessFromFileURLs method for the Qt LayoutTestController.
Attachments
Patch (4.01 KB, patch)
2009-12-04 12:47 PST, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2009-12-04 12:51:49 PST
style-queue ran check-webkit-style on attachment 44326 [details] without any errors.
Kenneth Rohde Christiansen
Comment 2 2009-12-04 13:02:33 PST
Reviewed by Adam Treat and landed in 51709
Eric Seidel (no email)
Comment 3 2009-12-04 14:49:37 PST
Comment on attachment 44326 [details] Patch Looks OK. I'm surprised that: + m_drt->webPage()->settings()->setAttribute(QWebSettings::LocalContentCanAccessRemoteUrls, enabled); uses a different way to get to settings than: m_topLoadingFrame->page()->settings()->setAttribute(QWebSettings::DeveloperExtrasEnabled, true);
Eric Seidel (no email)
Comment 4 2009-12-04 14:58:28 PST
Sigh. Please clear the r? when landing. :) bugzilla-tool land-attachment 44326 [details] will do that for you in case you need it...
Kenneth Rohde Christiansen
Comment 5 2009-12-05 06:49:11 PST
(In reply to comment #3) > (From update of attachment 44326 [details]) > Looks OK. I'm surprised that: > + > m_drt->webPage()->settings()->setAttribute(QWebSettings::LocalContentCanAccessRemoteUrls, > enabled); > > uses a different way to get to settings than: > > m_topLoadingFrame->page()->settings()->setAttribute(QWebSettings::DeveloperExtrasEnabled, > true); It is a bit inconsistent in the file, I will have a look at cleaning it up later.
Note You need to log in before you can comment on or make changes to this bug.