Bug 32168 - [Qt] Add setAllowUniversalAccessFromFileURLs to the LayoutTestController
Summary: [Qt] Add setAllowUniversalAccessFromFileURLs to the LayoutTestController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-04 12:47 PST by Kenneth Rohde Christiansen
Modified: 2009-12-05 06:49 PST (History)
2 users (show)

See Also:


Attachments
Patch (4.01 KB, patch)
2009-12-04 12:47 PST, Kenneth Rohde Christiansen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2009-12-04 12:47:27 PST
Created attachment 44326 [details]
Patch

Implement the setAllowUniversalAccessFromFileURLs method
    for the Qt LayoutTestController.
Comment 1 WebKit Review Bot 2009-12-04 12:51:49 PST
style-queue ran check-webkit-style on attachment 44326 [details] without any errors.
Comment 2 Kenneth Rohde Christiansen 2009-12-04 13:02:33 PST
Reviewed by Adam Treat and landed in 51709
Comment 3 Eric Seidel (no email) 2009-12-04 14:49:37 PST
Comment on attachment 44326 [details]
Patch

Looks OK.  I'm surprised that:
+    m_drt->webPage()->settings()->setAttribute(QWebSettings::LocalContentCanAccessRemoteUrls, enabled);

uses a different way to get to settings than:
     m_topLoadingFrame->page()->settings()->setAttribute(QWebSettings::DeveloperExtrasEnabled, true);
Comment 4 Eric Seidel (no email) 2009-12-04 14:58:28 PST
Sigh. Please clear the r? when landing. :)

bugzilla-tool land-attachment 44326 [details]

will do that for you in case you need it...
Comment 5 Kenneth Rohde Christiansen 2009-12-05 06:49:11 PST
(In reply to comment #3)
> (From update of attachment 44326 [details])
> Looks OK.  I'm surprised that:
> +   
> m_drt->webPage()->settings()->setAttribute(QWebSettings::LocalContentCanAccessRemoteUrls,
> enabled);
> 
> uses a different way to get to settings than:
>     
> m_topLoadingFrame->page()->settings()->setAttribute(QWebSettings::DeveloperExtrasEnabled,
> true);

It is a bit inconsistent in the file, I will have a look at cleaning it up later.