Bug 32164 - REGRESSION: AX: buttons now extremely repetitive
Summary: REGRESSION: AX: buttons now extremely repetitive
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2009-12-04 10:15 PST by chris fleizach
Modified: 2009-12-04 12:05 PST (History)
2 users (show)

See Also:

Attachments
patch (13.92 KB, patch)
2009-12-04 10:21 PST, chris fleizach 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2009-12-04 10:15:13 PST 
With VoiceOver

•  go to google.com
•  vo to a button

result:
text repeated..."google search, google search button"
Comment 1 chris fleizach 2009-12-04 10:15:18 PST 
AXValue is now being reported for AXButtons, which it should not.

AXValue shouldn't even be an attribute on AXButton

12/4/09 9:27 AM Chris Fleizach:
this was a regression from this change made for GTK
http://trac.webkit.org/changeset/46080

Comment 2 chris fleizach 2009-12-04 10:17:17 PST 
Eventually we need to re-organize the methods returning text data on elements in accessibility (i have a bug for that)... but the immediate fix is that AXButtons on the Mac, should never have AXValue being returned..
Comment 3 chris fleizach 2009-12-04 10:21:39 PST 
Created attachment 44322 [details]
patch
Comment 4 WebKit Review Bot 2009-12-04 10:24:24 PST 
Attachment 44322 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp:225:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 1
Comment 5 chris fleizach 2009-12-04 10:25:25 PST 
stylebot... i will make that change... please consider patch updated
Comment 6 chris fleizach 2009-12-04 12:05:06 PST 
http://trac.webkit.org/changeset/51706