Bug 32162 - Assert in BidiContext is wrong and only works by luck
Summary: Assert in BidiContext is wrong and only works by luck
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Adam Treat
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-04 08:57 PST by Adam Treat
Modified: 2009-12-04 09:14 PST (History)
1 user (show)

See Also:


Attachments
Fix for assert. (1.12 KB, patch)
2009-12-04 09:02 PST, Adam Treat
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Treat 2009-12-04 08:57:26 PST
The first assert in BidiContext only works through sheer luck.  The enum WTF::Unicode::Direction has LeftToRight == 0 and RightToLeft == 1 for both ICU and Qt4.  Other implementations that have different values for this enum will fail.  Fix coming...
Comment 1 Adam Treat 2009-12-04 09:02:48 PST
Created attachment 44319 [details]
Fix for assert.
Comment 2 WebKit Review Bot 2009-12-04 09:07:28 PST
style-queue ran check-webkit-style on attachment 44319 [details] without any errors.
Comment 3 Adam Treat 2009-12-04 09:14:43 PST
Landed with r51697.