Bug 32149 - [Qt] Doing right-click/Reload on a QWebInspector widget will close the widget
Summary: [Qt] Doing right-click/Reload on a QWebInspector widget will close the widget
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-12-04 02:50 PST by Jocelyn Turcotte
Modified: 2009-12-04 10:12 PST (History)
3 users (show)

See Also:


Attachments
Bug fix (1.62 KB, patch)
2009-12-04 03:24 PST, Jocelyn Turcotte
no flags Details | Formatted Diff | Diff
QtLauncher: add a menu to show/hide the inspector (2.54 KB, patch)
2009-12-04 03:26 PST, Jocelyn Turcotte
kenneth: review-
kenneth: commit-queue-
Details | Formatted Diff | Diff
QtLauncher: add a menu to show/hide the inspector V2 (2.53 KB, patch)
2009-12-04 08:20 PST, Jocelyn Turcotte
no flags Details | Formatted Diff | Diff
QtLauncher: corrects rest of the style issues (12.90 KB, patch)
2009-12-04 08:21 PST, Jocelyn Turcotte
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2009-12-04 02:50:23 PST
See patch
Comment 1 Jocelyn Turcotte 2009-12-04 03:24:13 PST
Created attachment 44300 [details]
Bug fix

This patch remove the widget close call in InspectorClientQt::closeWindow().
We needed it for the embedded close button in the inspector which has been hidden.
Comment 2 Jocelyn Turcotte 2009-12-04 03:26:03 PST
Created attachment 44301 [details]
QtLauncher: add a menu to show/hide the inspector

Adds the possibility to hide the inspector in QtLauncher with a toggle menu.
Comment 3 WebKit Review Bot 2009-12-04 03:28:33 PST
style-queue ran check-webkit-style on attachment 44300 [details] without any errors.
Comment 4 WebKit Review Bot 2009-12-04 03:28:54 PST
Attachment 44301 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/qt/QtLauncher/main.cpp:148:  This { should be at the end of the previous line  [whitespace/braces] [4]
WebKit/qt/QtLauncher/main.cpp:460:  Declaration has space between type name and * in QAction *showInspectorAction  [whitespace/declaration] [3]
WebKit/qt/QtLauncher/main.cpp:462:  Missing spaces around <<  [whitespace/operators] [3]
Total errors found: 3
Comment 5 Kenneth Rohde Christiansen 2009-12-04 04:49:34 PST
Comment on attachment 44301 [details]
QtLauncher: add a menu to show/hide the inspector


> +    WebInspector(QWidget* parent) : QWebInspector(parent) {}
> +signals:
> +    void visibilityChanged(bool nowVisible);

Qt already has a visibleChanged (slightly different name) for the QGraphicsObjects. Maybe we should use the same naming?


> +        QAction *showInspectorAction = toolsMenu->addAction("Show inspector", inspector, SLOT(setVisible(bool)));
> +        showInspectorAction->setCheckable(true);
> +        showInspectorAction->setShortcuts(QList<QKeySequence>()<<QKeySequence(tr("F12")));

I guess I would prefer spaces before and after the <<

But in general it LGTM. If you find it needed, make these changes before you commit.
Comment 6 Kenneth Rohde Christiansen 2009-12-04 04:53:10 PST
Comment on attachment 44301 [details]
QtLauncher: add a menu to show/hide the inspector

r- because of the style issues reported by the bot. It has better eyes than me :-)

I also missed this one here:

QAction *showInspectorAction

Fix that one as well please
Comment 7 WebKit Commit Bot 2009-12-04 04:56:57 PST
Comment on attachment 44300 [details]
Bug fix

Clearing flags on attachment: 44300

Committed r51694: <http://trac.webkit.org/changeset/51694>
Comment 8 WebKit Commit Bot 2009-12-04 04:57:02 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Kenneth Rohde Christiansen 2009-12-04 04:58:30 PST
There is still a patch that has not been landed, reopening.
Comment 10 Jocelyn Turcotte 2009-12-04 08:20:19 PST
Created attachment 44315 [details]
QtLauncher: add a menu to show/hide the inspector V2

here it is, with improved style
Comment 11 WebKit Review Bot 2009-12-04 08:20:58 PST
style-queue ran check-webkit-style on attachment 44315 [details] without any errors.
Comment 12 Jocelyn Turcotte 2009-12-04 08:21:24 PST
Created attachment 44316 [details]
QtLauncher: corrects rest of the style issues

to prevent over-complaining of the bot in the future for this file
Comment 13 WebKit Commit Bot 2009-12-04 10:05:02 PST
Comment on attachment 44315 [details]
QtLauncher: add a menu to show/hide the inspector V2

Clearing flags on attachment: 44315

Committed r51701: <http://trac.webkit.org/changeset/51701>
Comment 14 WebKit Commit Bot 2009-12-04 10:12:53 PST
Comment on attachment 44316 [details]
QtLauncher: corrects rest of the style issues

Clearing flags on attachment: 44316

Committed r51702: <http://trac.webkit.org/changeset/51702>
Comment 15 WebKit Commit Bot 2009-12-04 10:12:58 PST
All reviewed patches have been landed.  Closing bug.