See patch
Created attachment 44300 [details] Bug fix This patch remove the widget close call in InspectorClientQt::closeWindow(). We needed it for the embedded close button in the inspector which has been hidden.
Created attachment 44301 [details] QtLauncher: add a menu to show/hide the inspector Adds the possibility to hide the inspector in QtLauncher with a toggle menu.
style-queue ran check-webkit-style on attachment 44300 [details] without any errors.
Attachment 44301 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/qt/QtLauncher/main.cpp:148: This { should be at the end of the previous line [whitespace/braces] [4] WebKit/qt/QtLauncher/main.cpp:460: Declaration has space between type name and * in QAction *showInspectorAction [whitespace/declaration] [3] WebKit/qt/QtLauncher/main.cpp:462: Missing spaces around << [whitespace/operators] [3] Total errors found: 3
Comment on attachment 44301 [details] QtLauncher: add a menu to show/hide the inspector > + WebInspector(QWidget* parent) : QWebInspector(parent) {} > +signals: > + void visibilityChanged(bool nowVisible); Qt already has a visibleChanged (slightly different name) for the QGraphicsObjects. Maybe we should use the same naming? > + QAction *showInspectorAction = toolsMenu->addAction("Show inspector", inspector, SLOT(setVisible(bool))); > + showInspectorAction->setCheckable(true); > + showInspectorAction->setShortcuts(QList<QKeySequence>()<<QKeySequence(tr("F12"))); I guess I would prefer spaces before and after the << But in general it LGTM. If you find it needed, make these changes before you commit.
Comment on attachment 44301 [details] QtLauncher: add a menu to show/hide the inspector r- because of the style issues reported by the bot. It has better eyes than me :-) I also missed this one here: QAction *showInspectorAction Fix that one as well please
Comment on attachment 44300 [details] Bug fix Clearing flags on attachment: 44300 Committed r51694: <http://trac.webkit.org/changeset/51694>
All reviewed patches have been landed. Closing bug.
There is still a patch that has not been landed, reopening.
Created attachment 44315 [details] QtLauncher: add a menu to show/hide the inspector V2 here it is, with improved style
style-queue ran check-webkit-style on attachment 44315 [details] without any errors.
Created attachment 44316 [details] QtLauncher: corrects rest of the style issues to prevent over-complaining of the bot in the future for this file
Comment on attachment 44315 [details] QtLauncher: add a menu to show/hide the inspector V2 Clearing flags on attachment: 44315 Committed r51701: <http://trac.webkit.org/changeset/51701>
Comment on attachment 44316 [details] QtLauncher: corrects rest of the style issues Clearing flags on attachment: 44316 Committed r51702: <http://trac.webkit.org/changeset/51702>