Bug 32148 - New History changes do not compile for Chromium/V8
Summary: New History changes do not compile for Chromium/V8
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-03 22:16 PST by Andrew Wilson
Modified: 2009-12-16 12:17 PST (History)
5 users (show)

See Also:


Attachments
proposed patch (7.63 KB, patch)
2009-12-03 22:30 PST, Andrew Wilson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Wilson 2009-12-03 22:16:05 PST
The new history "pushState" support added in r51644 don't work (compile) under V8/Chromium.

We need to add appropriate V8 bindings and chromium versions of the new History APIs.
Comment 1 Andrew Wilson 2009-12-03 22:30:01 PST
Created attachment 44295 [details]
proposed patch
Comment 2 Adam Barth 2009-12-03 22:31:26 PST
Comment on attachment 44295 [details]
proposed patch

ok
Comment 3 Andrew Wilson 2009-12-03 22:42:36 PST
landed initial patch to allow chromium to compile as r51681.

pushState()/replaceState() are just stubbed out for now in Chromium.
Comment 4 Adam Barth 2009-12-03 23:26:51 PST
Comment on attachment 44295 [details]
proposed patch

This has landed.
Comment 5 Darin Fisher (:fishd, Google) 2009-12-16 12:17:26 PST
Closing this bug since we now compile.  I'll open another bug about implementing BackForwardListChromium.cpp and related bits.  (See also: http://code.google.com/p/chromium/issues/detail?id=29393)