RESOLVED FIXED 32124
[Qt] Debug version of DumpRenderTree crashes 
https://bugs.webkit.org/show_bug.cgi?id=32124
Summary [Qt] Debug version of DumpRenderTree crashes
Chang Shu
Reported Thursday, December 3, 2009 6:34:55 PM UTC
I was running the debug version of DumpRenderTree to debug some layout tests. But it crashed every time. The core dump is related to the following code in LayoutTestControllerQt.cpp: void LayoutTestController::maybeDump(bool success) { Q_ASSERT(sender() == m_topLoadingFrame); ...
Attachments
fix patch (1.21 KB, patch)
2009-12-03 10:37 PST, Chang Shu 		no flags
DetailsFormatted DiffDiff
a better fix (1.21 KB, patch)
2009-12-03 11:05 PST, Chang Shu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chang Shu
Comment 1 Thursday, December 3, 2009 6:37:24 PM UTC
Created attachment 44256 [details] fix patch I have to fix it as it blocked my work.
WebKit Review Bot
Comment 2 Thursday, December 3, 2009 6:42:07 PM UTC
style-queue ran check-webkit-style on attachment 44256 [details] without any errors.
Chang Shu
Comment 3 Thursday, December 3, 2009 7:05:29 PM UTC
Created attachment 44257 [details] a better fix Checking against the right object in assertion is better than removing it completely.
WebKit Review Bot
Comment 4 Thursday, December 3, 2009 7:07:47 PM UTC
style-queue ran check-webkit-style on attachment 44257 [details] without any errors.
WebKit Commit Bot
Comment 5 Thursday, December 3, 2009 10:08:29 PM UTC
Comment on attachment 44257 [details] a better fix Clearing flags on attachment: 44257 Committed r51662: <http://trac.webkit.org/changeset/51662>
WebKit Commit Bot
Comment 6 Thursday, December 3, 2009 10:08:39 PM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.