Bug 32118 - Chromium: Add support for settings containing ":"
Summary: Chromium: Add support for settings containing ":"
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2009-12-03 07:57 PST by Pavel Feldman
Modified: 2010-06-01 22:23 PDT (History)
6 users (show)

See Also:

[PATCH] The fix (3.10 KB, patch)
2009-12-03 08:04 PST, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-12-03 07:57:00 PST
Current escaping does not handle ":".
Aslo has a drive-by fix for setting group id early.
Comment 1 Pavel Feldman 2009-12-03 08:04:17 PST
Created attachment 44242 [details]
[PATCH] The fix
Comment 2 WebKit Review Bot 2009-12-03 08:06:08 PST
style-queue ran check-webkit-style on attachment 44242 [details] without any errors.
Comment 3 Pavel Feldman 2009-12-03 08:45:43 PST
Sending        WebCore/ChangeLog
Sending        WebCore/inspector/front-end/WatchExpressionsSidebarPane.js
Sending        WebKit/chromium/ChangeLog
Sending        WebKit/chromium/src/InspectorClientImpl.cpp
Transmitting file data ....Committed revision 51637.
Comment 4 WebKit Review Bot 2010-06-01 03:32:06 PDT
http://trac.webkit.org/changeset/60469 might have broken Qt Linux ARMv5 Release
Comment 5 Timothy Hatcher 2010-06-01 05:41:42 PDT
This Qt Linux bot shit is getting old.
Comment 6 Eric Seidel (no email) 2010-06-01 22:23:30 PDT
Yup.  Since the Qt bots still seem to have network issues, we're going to try bug 39282 as a workaround.  We could also just remove them from the set of builders the sherriffbot watches.