Bug 32113 - [Qt] Use DirectConnection for the QNetworkReply in the QNetworkReplyHandler
Summary: [Qt] Use DirectConnection for the QNetworkReply in the QNetworkReplyHandler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-03 03:23 PST by Holger Freyther
Modified: 2009-12-15 08:20 PST (History)
3 users (show)

See Also:


Attachments
Use direct Qt signal connections (3.14 KB, patch)
2009-12-03 03:23 PST, Holger Freyther
no flags Details | Formatted Diff | Diff
[Qt] Followup for direct signals and slots connections in QNetworkReplyHandler (2.57 KB, patch)
2009-12-15 01:10 PST, Holger Freyther
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Freyther 2009-12-03 03:23:49 PST
Created attachment 44224 [details]
Use direct Qt signal connections

We should use DirectConnection to achieve a improvement in latency on network jobs. This also means that the loading will be more stable across different runs. The only possible problem is that it might cause crashes on Qt4.5 and Qt4.6... we will have to figure if it is crashing or not.
Comment 1 WebKit Review Bot 2009-12-14 01:22:55 PST
style-queue ran check-webkit-style on attachment 44224 [details] without any errors.
Comment 2 Holger Freyther 2009-12-14 03:22:20 PST
Landed it in r52089. Waiting for the bot to run the tests before closing the bug.
Comment 3 Holger Freyther 2009-12-14 05:09:14 PST
mgoetz just highlighted that I have blindly converted everything to DirectConnection. With some luck I'm not reverting bug #25556. Once we are confident that it is not crashing we should remove the signal and do a direct function call again.
Comment 4 Markus Goetz 2009-12-15 00:08:10 PST
This patch depends on a bugfix inside Qt 4.6.
It should hit qt.gitorious.org in the next days.
http://pastebin.ca/1714463
Comment 5 Holger Freyther 2009-12-15 01:10:45 PST
Created attachment 44852 [details]
[Qt] Followup for direct signals and slots connections in QNetworkReplyHandler
Comment 6 WebKit Review Bot 2009-12-15 01:14:07 PST
style-queue ran check-webkit-style on attachment 44852 [details] without any errors.
Comment 7 Simon Hausmann 2009-12-15 07:08:18 PST
Comment on attachment 44852 [details]
[Qt] Followup for direct signals and slots connections in QNetworkReplyHandler

Good idea and good save :), r=me
Comment 8 Holger Freyther 2009-12-15 08:20:02 PST
Landed in r52153.