Created attachment 44221 [details] Patch Inherits the following class from Noncopyable because it is instantiated by 'new' and no need to be copyable: class name - instantiated at: WebCore/'location' class FrameLoaderClient - (its child class) svg/graphics/SVGImage.cpp:229
style-queue ran check-webkit-style on attachment 44221 [details] without any errors.
Comment on attachment 44221 [details] Patch Are you using a script to find these?
Comment on attachment 44221 [details] Patch Are you sure this is right? This is just an abstract interface.
(In reply to comment #2) > (From update of attachment 44221 [details]) > Are you using a script to find these? No, I'm using a static source analyzer tool (called Columbus, developed by our department) and check the results by 'hand'. (In reply to comment #3) > (From update of attachment 44221 [details]) > Are you sure this is right? This is just an abstract interface. This is right, but not necessary, so okay, in the future at the case of abstract interfaces I won't go up to the superclass in the inheritance tree.
Hmm. I checked. This is the instantiation line: static FrameLoaderClient* dummyFrameLoaderClient = new EmptyFrameLoaderClient; So, I have to inherit either EmptyFrameLoaderClient or FrameLoaderClient which are both abstract interfaces. FrameLoaderClient is the super class of EmptyFrameLoaderClient, so firt FrameLoaderClient should be inherited. (If some classes inherit from Noncopyable it also inherit from FastAllocBase, so the customization of the new/delete operator will be done.)
Created attachment 44674 [details] Patch
Ignore my last comments. You're right! New patch updated and filed!
style-queue ran check-webkit-style on attachment 44674 [details] without any errors.
Comment on attachment 44674 [details] Patch Clearing flags on attachment: 44674 Committed r51990: <http://trac.webkit.org/changeset/51990>
All reviewed patches have been landed. Closing bug.